Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate .NET Framework 4.6.2 to .NET 6 #29

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SoftStoneDevelop
Copy link

Why not.
Also updated all nuggets.

@SoftStoneDevelop SoftStoneDevelop changed the title Migrate .NET Framework 4.6.2 to .NET 5 Migrate .NET Framework 4.6.2 to .NET 6 Jun 25, 2022
@virzak
Copy link

virzak commented Sep 2, 2022

Is this getting merged?

@SoftStoneDevelop
Copy link
Author

One thing - I did not do unit tests. Because the new version of the svg->xaml converter adds unique element guid's each time.

I thought to discuss this with the owner of the repository, but there has been silence for a long time. And so everything works correctly.

@virzak
Copy link

virzak commented Sep 2, 2022

Also, I was wondering. Why isn't this targeted to .Net Standard 2.0?

Update: Never mind. I see it uses SharpVectors.Converters.Wpf.

@paulushub
Copy link

One thing - I did not do unit tests. Because the new version of the svg->xaml converter adds unique element guid's each time.

That was experimental feature for hit testing and it is removed now. In the previous release before 1.8.0, you can simple set the interactivity property in the settings to None and no ID is appended.
Moreover, the new version of the SharpVectors 1.8.0, contains ResourceSvgConverter, so you can completely discard ConverterLogic and related classes.
Take a look at the WpfTestResourceSvg sample to see the features exposed by the new converter class.

While developing the new features, I posted an invitation #30 to test it and provide feedbacks, but there was no response.

@SoftStoneDevelop
Copy link
Author

Test app(WpfTestSvgSample) at https://github.com/ElinamLLC/SharpVectors does the same or not? So this project is not so necessary. The funny thing is that the original library (on the basis of which this project is made) SharpVectors has fewer stars.

@paulushub
Copy link

Test app (WpfTestSvgSample) at https://github.com/ElinamLLC/SharpVectors does the same or not?

WpfTestSvgSample is simply a demo sample for the ResourceSvgConverter class, it does not provide the command-line processing, configuration serialization etc.

So this project is not so necessary.

It is necessary. It can be simplified though, by using the new converter class. The new converter class can use multiple directory sources that is not demonstrated by WpfTestSvgSample for instance.

The funny thing is that the original library (on the basis of which this project is made) SharpVectors has fewer stars.

This app extended SharpVectors to provide ResourceDictionary output file, which is only available in SharpVectors 1.8.0+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants