Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SOVERSION is not used when building a shared library for Linux. #46

Open
expeehaa opened this issue Feb 21, 2024 · 0 comments
Open

Comments

@expeehaa
Copy link

The comment in line 619 says that the SOVERSION should only be set if the system is not Android, but the line setting the SOVERSION for the shared library is in a conditional branch that is only run when building for Android.

if(ANDROID)
if(VPX_FOUND)
set_target_properties(mediastreamer2 PROPERTIES LINK_FLAGS "-Wl,--exclude-libs,libvpx.a")
endif()
# Do not version shared library on Android
set_target_properties(mediastreamer2 PROPERTIES SOVERSION ${MEDIASTREAMER_SO_VERSION})
else()

Until this commit the lines which are now 619 and 620 were correctly in the else branch of the Android condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant