Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a:b in defines #11864

Open
PowerfulBacon opened this issue Nov 9, 2024 · 1 comment
Open

Remove a:b in defines #11864

PowerfulBacon opened this issue Nov 9, 2024 · 1 comment
Labels
Priority: High Triaged Issues that are exempt from the stale action

Comments

@PowerfulBacon
Copy link
Member

a:b syntax can massively increase compile times, I had ~5-6 calls inside of a define that was called ~400 times, which increased compilation times by 2 minutes. With some very, very rough maths that means each a:b call is something like 50ms of compile time, which when inside a define that is used a lot can really increase the compilation times.

I only noticed this due to a single PR increasing it to ~2:30 minutes, but we could have had smaller PRs adding these going under the radar.

@PowerfulBacon PowerfulBacon added Triaged Issues that are exempt from the stale action Priority: High labels Nov 9, 2024
@PowerfulBacon
Copy link
Member Author

PowerfulBacon commented Nov 15, 2024

Opendream have added a lint against this, which we can use (OD3300)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Triaged Issues that are exempt from the stale action
Projects
None yet
Development

No branches or pull requests

1 participant