From 6d71e23792512b04d445ce07a335b21c0880520c Mon Sep 17 00:00:00 2001 From: h4r7w3l1 <36492399+h4r7w3l1@users.noreply.github.com> Date: Tue, 5 Dec 2023 16:01:42 +0300 Subject: [PATCH 1/2] fix: Issue `go install` exits invalid character '\'', this commit rename the data type classification file contained single quotation marks "Mother's Maiden Name". --- .../{18_mother's_maiden_name.json => 18_mothers_maiden_name.json} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename internal/classification/db/data_type_classification_patterns/{18_mother's_maiden_name.json => 18_mothers_maiden_name.json} (100%) diff --git a/internal/classification/db/data_type_classification_patterns/18_mother's_maiden_name.json b/internal/classification/db/data_type_classification_patterns/18_mothers_maiden_name.json similarity index 100% rename from internal/classification/db/data_type_classification_patterns/18_mother's_maiden_name.json rename to internal/classification/db/data_type_classification_patterns/18_mothers_maiden_name.json From fe19d7cc5153edbb2ef8fef87e96475c15e4e115 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Fabianski?= Date: Wed, 6 Dec 2023 10:25:40 +0100 Subject: [PATCH 2/2] fix: update snapshots --- internal/classification/schema/.snapshots/TestJavascript | 4 ++-- internal/classification/schema/.snapshots/TestJavascriptKPI | 4 ++-- internal/classification/schema/.snapshots/TestPHP | 4 ++-- internal/classification/schema/.snapshots/TestPHPKPI | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/internal/classification/schema/.snapshots/TestJavascript b/internal/classification/schema/.snapshots/TestJavascript index 7c4a9b6e9..7f4762eed 100644 --- a/internal/classification/schema/.snapshots/TestJavascript +++ b/internal/classification/schema/.snapshots/TestJavascript @@ -1729,8 +1729,8 @@ (string) (len=17) "MothersMaidenName": (testhelper.ClassificationResult) { Name: (string) (len=17) "MothersMaidenName", Decision: (classify.ClassificationDecision) { - State: (classify.ValidationState) (len=7) "invalid", - Reason: (string) (len=16) "invalid_property" + State: (classify.ValidationState) (len=5) "valid", + Reason: (string) (len=21) "valid_unknown_pattern" }, Properties: (map[string]testhelper.ClassificationResult) }, diff --git a/internal/classification/schema/.snapshots/TestJavascriptKPI b/internal/classification/schema/.snapshots/TestJavascriptKPI index 1840f9729..400cfa405 100644 --- a/internal/classification/schema/.snapshots/TestJavascriptKPI +++ b/internal/classification/schema/.snapshots/TestJavascriptKPI @@ -1,8 +1,8 @@ (testhelper.KPI) { DetectionsCount: (int) 445, - ValidDetectionsCount: (int) 122, + ValidDetectionsCount: (int) 123, ValidObjectDetectionsCount: (int) 38, - ValidFieldDetectionsCount: (int) 84, + ValidFieldDetectionsCount: (int) 85, ExpectedValidDetectionsCount: (int) 135, ExpectedValidObjectDetectionsCount: (int) 46, ExpectedValidFieldDetectionsCount: (int) 89, diff --git a/internal/classification/schema/.snapshots/TestPHP b/internal/classification/schema/.snapshots/TestPHP index 854276b60..453b1d407 100644 --- a/internal/classification/schema/.snapshots/TestPHP +++ b/internal/classification/schema/.snapshots/TestPHP @@ -1392,8 +1392,8 @@ (string) (len=16) "mothermaidenname": (testhelper.ClassificationResult) { Name: (string) (len=16) "mothermaidenname", Decision: (classify.ClassificationDecision) { - State: (classify.ValidationState) (len=7) "invalid", - Reason: (string) (len=16) "invalid_property" + State: (classify.ValidationState) (len=5) "valid", + Reason: (string) (len=21) "valid_unknown_pattern" }, Properties: (map[string]testhelper.ClassificationResult) }, diff --git a/internal/classification/schema/.snapshots/TestPHPKPI b/internal/classification/schema/.snapshots/TestPHPKPI index c5997156f..7a14ed7b1 100644 --- a/internal/classification/schema/.snapshots/TestPHPKPI +++ b/internal/classification/schema/.snapshots/TestPHPKPI @@ -1,8 +1,8 @@ (testhelper.KPI) { DetectionsCount: (int) 353, - ValidDetectionsCount: (int) 119, + ValidDetectionsCount: (int) 120, ValidObjectDetectionsCount: (int) 27, - ValidFieldDetectionsCount: (int) 92, + ValidFieldDetectionsCount: (int) 93, ExpectedValidDetectionsCount: (int) 143, ExpectedValidObjectDetectionsCount: (int) 33, ExpectedValidFieldDetectionsCount: (int) 110,