Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test annotations #1507

Open
gotbadger opened this issue Feb 21, 2024 · 0 comments
Open

Improve test annotations #1507

gotbadger opened this issue Feb 21, 2024 · 0 comments
Labels
CI Improving continuous integration sytstem

Comments

@gotbadger
Copy link
Contributor

Description & Reproduction

For testing rules we use an annoation format

In this case the expected finding is expected to come from the line of the comment

begin
  1/0
rescue ZeroDivisionError => ex
  # bearer:expected ruby_third_parties_airbrake
  response = Airbrake.notify_sync(current_user.first_name)
end

In this case the expected finding is correctly marked as the line below the annoation

begin
  1/0
rescue ZeroDivisionError => ex
  1+1
  # bearer:expected ruby_third_parties_airbrake
  response = Airbrake.notify_sync(current_user.first_name)
end
@gotbadger gotbadger added bug Something isn't working CI Improving continuous integration sytstem labels Feb 21, 2024
@gotbadger gotbadger changed the title Test annoations somtimes are not marked correctly Test annoations sometimes are not marked correctly Feb 21, 2024
@gotbadger gotbadger removed the bug Something isn't working label Feb 29, 2024
@gotbadger gotbadger changed the title Test annoations sometimes are not marked correctly Test annoations sometimes are not marked as expected Feb 29, 2024
@gotbadger gotbadger changed the title Test annoations sometimes are not marked as expected Improve test annotations Feb 29, 2024
@cfabianski cfabianski removed their assignment Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Improving continuous integration sytstem
Projects
None yet
Development

No branches or pull requests

2 participants