From c0896e57edf91d4785301800d6bba054a2f3cfe7 Mon Sep 17 00:00:00 2001
From: gotbadger <p.j.h@hey.com>
Date: Tue, 19 Sep 2023 12:51:44 +0100
Subject: [PATCH] docs: fix uses of continue-on-error

---
 docs/guides/github-action.njk | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/docs/guides/github-action.njk b/docs/guides/github-action.njk
index 96dbf1e4a..1ccac7cd9 100644
--- a/docs/guides/github-action.njk
+++ b/docs/guides/github-action.njk
@@ -143,7 +143,6 @@ permissions:
 jobs:
   rule_check:
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v3
       - name: Run Report
@@ -177,9 +176,12 @@ permissions:
 jobs:
   rule_check:
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v3
++     # install reviewdog
+      - uses: reviewdog/action-setup@v1
+        with:
+          reviewdog_version: latest
       - name: Run Report
         id: report
         uses: bearer/bearer-action@v2
@@ -188,11 +190,9 @@ jobs:
           format: rdjson
           output: rd.json
           diff: true
-+     # add steps to setup and run reviewdog
-      - uses: reviewdog/action-setup@v1
-        with:
-          reviewdog_version: latest
++     # always run reviewdog otherwise the step will be skiped by github when a scan fails
       - name: Run reviewdog
+        if: always()
         env:
           REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
@@ -217,7 +217,6 @@ permissions:
 jobs:
   rule_check:
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v3
       - name: Run Report
@@ -227,6 +226,7 @@ jobs:
           format: gitlab-sast
           output: gl-sast-report.json
       - name: Defect Dojo
+        if: always()
         env:
           DD_TOKEN: ${{ secrets.DD_TOKEN}}
           DD_APP: ${{ secrets.DD_APP}}