Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared JS rule to catch more TS Response objects #311

Open
elsapet opened this issue Feb 23, 2024 · 0 comments
Open

Add shared JS rule to catch more TS Response objects #311

elsapet opened this issue Feb 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@elsapet
Copy link
Collaborator

elsapet commented Feb 23, 2024

As we do with the Request object, we should be agnostic about what the Response object is named in TS.

e.g. patterns concerning the Response object should match on whatever here

  function(req: Request, whatever: Response) { 
    whatever.redirect(...)
  }

This is relevant to rules that match on res e.g. javascript_express_open_redirect.

See javascript_hapi_open_redirect rule for an example of the patterns: #309

@elsapet elsapet added the enhancement New feature or request label Feb 23, 2024
@elsapet elsapet changed the title Add shared JS rule to catch "response"-type objects in TS Add shared JS rule to catch more TS Response objects Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant