Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Reformat robot code #8

Merged
merged 2 commits into from
Oct 25, 2024
Merged

style: Reformat robot code #8

merged 2 commits into from
Oct 25, 2024

Conversation

NyxAlexandra
Copy link
Member

Mostly line spacing/break, conversions of coments to doc comments, and fixing of doc links for some functions. I intentionally ignored most of the formatting for subsystems as, though I don't like leaving unused/commented-out code sitting, leaving them makes this commit easier to just merge.

NyxAlexandra and others added 2 commits October 25, 2024 16:56
Mostly line spacing/break, conversions of coments to doc comments,
and fixing of doc links for some functions. I intentionally ignored
most of the formatting for subsystems as, though I don't like leaving
unused/commented-out code sitting, leaving them makes this commit
easier to just merge.
This commit fixes the style issues introduced in f5778d3 according to the output
from Ktlint.

Details: #8
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

deepsource-io bot commented Oct 25, 2024

Here's the code health analysis summary for commits bdfeff8..e1f5e27. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Kotlin LogoKotlin❌ Failure
❗ 12 occurences introduced
🎯 16 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@TheGamer1002 TheGamer1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NyxAlexandra NyxAlexandra merged commit 6769e0e into main Oct 25, 2024
7 of 8 checks passed
@github-actions github-actions bot deleted the dev/general-refactoring branch November 2, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants