Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume General category in settings command #316

Open
lionkor opened this issue May 7, 2024 · 5 comments
Open

Assume General category in settings command #316

lionkor opened this issue May 7, 2024 · 5 comments
Labels
feature New feature or request

Comments

@lionkor
Copy link
Member

lionkor commented May 7, 2024

Typing settings set General MaxPlayers 34 is more common than setting Misc or other settings, and thus we should provide overloads for settings set which only take a setting name, and either:

  • bail out + refuse when it's ambiguous, or
  • assume General and roll with it.

Related to #295

@lionkor lionkor added the feature New feature or request label May 7, 2024
@jimkoen
Copy link
Collaborator

jimkoen commented May 13, 2024

I'd rather we drop namespaces completely (so far we only have two values for the Misc namespace) or add a mandatory delimiter with auto-completion, like general::max_players.

@lionkor
Copy link
Member Author

lionkor commented May 13, 2024

We need them for later plugin settings support.

Autocomplete should be trivial to add, lets do that

@Neptnium
Copy link
Contributor

@lionkor I feel like putting every plugin in the main config file would be a bad idea.
It could quickly become a huge mess, I personally have my plugins create a shared "configs" folder at the root of the server files, and every plugin create its own .TOML config file with the name of the plugin. (Kinda like minecraft even tho minecraft plugin's config are in the same folder as plugins, but its not possible in beammp as every folder is treated like a plugin in the servers resource folder)

Putting every plugin in the main would have issues when removing a plugin from the server and if plugins have big configs (My next plugin has like 30+ config settings, would be a mess if there are multiple like that)

@lionkor
Copy link
Member Author

lionkor commented May 14, 2024

Either way I'd like to be able to query and change settings via the server cli

@Neptnium
Copy link
Contributor

Yeah, I agree, would be a good idea, but just the fact of having every plugin's config in the same file would be a bad idea for me, Idk if you understand my opinion but yeah a cli command to change settings would be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants