Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl->ch should not be private #81

Open
delatbabel opened this issue Jan 7, 2016 · 0 comments
Open

Curl->ch should not be private #81

delatbabel opened this issue Jan 7, 2016 · 0 comments

Comments

@delatbabel
Copy link

Because of the missing ability to set curl options in the base classes as provided I had to write my own extended version of the classes here.

So I have a SoapClientBuilder that extends BeSimple\SoapClient\SoapClientBuilder and passes the options down stream.

Another class SoapClient that extends BeSimple\SoapClient\SoapClient and replaces the constructor so that it replaces only the $this->curl with my own Curl class.

Another class Curl that extends BeSimple\SoapClient\Curl that would like to set options in $this->ch BUT IT CAN'T BECAUSE YOU HAVE MADE THE $ch PROPERTY PRIVATE.

Making a property private means that no subclass can access it. So you can see into the future to know that nobody who wants to extend your class will need to access that property.

Can you really see into the future?

I would submit a PR for this but I see from the backlog of PRs that nothing is being done to incorporate those. e.g. if you merged #63 this would partially resolve that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant