You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because of the missing ability to set curl options in the base classes as provided I had to write my own extended version of the classes here.
So I have a SoapClientBuilder that extends BeSimple\SoapClient\SoapClientBuilder and passes the options down stream.
Another class SoapClient that extends BeSimple\SoapClient\SoapClient and replaces the constructor so that it replaces only the $this->curl with my own Curl class.
Another class Curl that extends BeSimple\SoapClient\Curl that would like to set options in $this->ch BUT IT CAN'T BECAUSE YOU HAVE MADE THE $ch PROPERTY PRIVATE.
Making a property private means that no subclass can access it. So you can see into the future to know that nobody who wants to extend your class will need to access that property.
Can you really see into the future?
I would submit a PR for this but I see from the backlog of PRs that nothing is being done to incorporate those. e.g. if you merged #63 this would partially resolve that problem.
The text was updated successfully, but these errors were encountered:
Because of the missing ability to set curl options in the base classes as provided I had to write my own extended version of the classes here.
So I have a SoapClientBuilder that extends BeSimple\SoapClient\SoapClientBuilder and passes the options down stream.
Another class SoapClient that extends BeSimple\SoapClient\SoapClient and replaces the constructor so that it replaces only the $this->curl with my own Curl class.
Another class Curl that extends BeSimple\SoapClient\Curl that would like to set options in $this->ch BUT IT CAN'T BECAUSE YOU HAVE MADE THE $ch PROPERTY PRIVATE.
Making a property private means that no subclass can access it. So you can see into the future to know that nobody who wants to extend your class will need to access that property.
Can you really see into the future?
I would submit a PR for this but I see from the backlog of PRs that nothing is being done to incorporate those. e.g. if you merged #63 this would partially resolve that problem.
The text was updated successfully, but these errors were encountered: