Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest required packages #50

Open
rdohms opened this issue Sep 9, 2014 · 0 comments
Open

Don't suggest required packages #50

rdohms opened this issue Sep 9, 2014 · 0 comments

Comments

@rdohms
Copy link

rdohms commented Sep 9, 2014

Trying out this bundle and i see it suggests besimple/soap-client, however the client builder has a hard dependency on this class use BeSimple\SoapClient\SoapClientBuilder as BaseSoapClientBuilder;

This means this should be in your require, not a suggestion. For it to be a suggestion you would have to make it so this class can be replaced by another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant