Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of multiple solutions for overpotential #52

Open
rkurchin opened this issue Aug 15, 2022 · 0 comments
Open

More robust handling of multiple solutions for overpotential #52

rkurchin opened this issue Aug 15, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rkurchin
Copy link
Member

Currently, there can be some wacky behavior when there are multiple valid solutions for overpotential (e.g. before and after inverted region in a Marcus model, or around nonmonotonicities in MHC+DOS models). It would be good to have smarter ways to detect that....in the Marcus case, we know analytically when the inverted region starts, so could try to constrain search to be before it. For MHC+DOS it's a bit trickier, might need to add some stochasticity to the optimizer to find the best minimum and also balance against wanting the lowest-voltage good solution...

@rkurchin rkurchin added the bug Something isn't working label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant