Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack #1

Closed
krthr opened this issue Jul 1, 2019 · 12 comments
Closed

Webpack #1

krthr opened this issue Jul 1, 2019 · 12 comments

Comments

@krthr
Copy link
Contributor

krthr commented Jul 1, 2019

Hey! Great lib...

I have a question... what are you using to minify the .js? Why dont you use Webpack?

@krthr
Copy link
Contributor Author

krthr commented Jul 1, 2019

I could help adding the webpack config... And.. we could publish it on npm!

@BaseMax
Copy link
Owner

BaseMax commented Jul 2, 2019

Hey @krthr,

Thank so much,

what are you using to minify the .js?

A tool and service.
I did not remember this at now.
It's important?

Why don't you use Webpack?

Do you want to create a website using Nodejs?
We can do it...
Do you help to do it?

Regards,
Max

@BaseMax
Copy link
Owner

BaseMax commented Jul 2, 2019

I could help adding the webpack config...

Thanks,

And.. we could publish it on npm!

Yeah, of course, I have an account there.

@krthr
Copy link
Contributor Author

krthr commented Jul 2, 2019

It's important?

It would be nice to be able to install FilterInputJs via npm. Webpack will help build the file for production automatically.

@krthr
Copy link
Contributor Author

krthr commented Jul 2, 2019

#2

@BaseMax
Copy link
Owner

BaseMax commented Jul 2, 2019

Hey @krthr,

Thank so much,

Wow, we have published this package...
https://www.npmjs.com/package/filterinput

Can you complete the Filters feature and TODO list?

Regards,
Max

@krthr
Copy link
Contributor Author

krthr commented Jul 3, 2019

Hey @krthr,

Thank so much,

Wow, we have published this package...
https://www.npmjs.com/package/filterinput

Can you complete the Filters feature and TODO list?

Regards,
Max

Great!
I will see the TODO items and try to complete the filters

@BaseMax
Copy link
Owner

BaseMax commented Jul 3, 2019

Great!
I will see the TODO items and try to complete the filters

Hi,

Thank you @krthr,

At first, please not work on the restrict allowed languages.
Because it requires deep knowledge from UTF-8.
#4

We can do it in the next step.

Regards,
Max

@BaseMax
Copy link
Owner

BaseMax commented Jul 7, 2019

Hi,

How are you? @krthr

Regards,
Max

@krthr
Copy link
Contributor Author

krthr commented Jul 7, 2019

Hi! It was a busy week ;) I'm working in the data-filter-lang item.

@krthr
Copy link
Contributor Author

krthr commented Jul 7, 2019

I think we can access to the data attributes using the dataset property
https://developer.mozilla.org/en-US/docs/Learn/HTML/Howto/Use_data_attributes

@BaseMax
Copy link
Owner

BaseMax commented Jul 28, 2019

Hi,

How are you?
What's up? @krthr

Regards,
Max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants