feat: page validateur bal #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaGOs92
force-pushed
the
gfay_feat_validateur-bal
branch
from
d10b80c to
7f9d60b
Compare
MaGOs92
force-pushed
the
gfay_feat_validateur-bal
branch
2 times, most recently
from
63e3e14 to
844f354
Compare
nkokla
reviewed
Sep 30, 2024
| @@ -35,6 +38,7 @@ | |||
| "remark": "^15.0.1", | |||
| "remark-heading-id": "^1.0.1", | |||
| "remark-html": "^16.0.1", | |||
| "sharp": "^0.33.5", | |||
There was a problem hiding this comment.
Hello @MaGOs92 !
Pourquoi a t'on besoin de sharp ?
There was a problem hiding this comment.
Salut Nicolas, c'est une recommandation que j'ai vu dans les logs de build de Scalingo
There was a problem hiding this comment.
C'est très étrange. Le log precise dans quel cas il a besoin de cette dependances ?
Au pire, est-ce qu'il ne devrait pas être en devDependencies ?
There was a problem hiding this comment.
Voici le log en question :
There was a problem hiding this comment.
En faite c'est pas au build mais au runtime qu'apparait ce log
There was a problem hiding this comment.
En fait il faut installer la dépendance sharp non présent dans next.js : https://nextjs.org/docs/messages/sharp-missing-in-production
MaGOs92
force-pushed
the
gfay_feat_validateur-bal
branch
from
c6f5af3 to
e928056
Compare
MaGOs92
force-pushed
the
gfay_feat_validateur-bal
branch
from
1149548 to
9bcae0b
Compare
vinsag
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajoute le validateur BAL