-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color calibration profiles download feature (X-Rite replacement) #1480
Comments
What do you mean by 'not working for everyone?' XRite function is only provided for legion 7 or higher models as I know. I'm wondering if you mean XRite sometimes doesn't work on those officially supported models or just, not for all models. But it's really cool if we can implement this. If needed I can also provide datas for chinese-specific models with XRite. |
I mean, it fails on officially supported models like in my case. Looks like it happens not quite often but also i'm sure not all hardware owners go ahead and figure out they can obtain color profiles from a 3rd party app even if it's offered on support page. I honestly have no idea what models or product lines are color-calibrated and supported by XRite with cloud color profile downloads. I just found that thread on Lenovo site and it appears there are other users who can't get XRite to work. Notably this is Thinkpad support forum, not Legion - so maybe i'm the lucky one Legion owner with bad .zip in their cloud. Still, other users figured out what the algorithm is and i compiled this knowledge together so maybe it will be useful for other Legion owners to avoid bloatware. XRite app is 127 megabytes and all it does is download zip + install |
Weird. I'll go over all info you provided. Tbh I'm also worrying if the XRite provided on my device, which is chinese-specific, works differently since that's the thing lenovo does all the time, but I'll give some tests.
Indeed xD. |
Check out the thread i linked, it has all the info how XRite works: we sniffed its traffic, checked the logs, and replicated profile install manually to make app happy and get through errors. So one can pretty much figure out how it works |
This seems like a neat addition. The only problem is that, from what I know X-Rite applies some additional transformations to the icm files before importing them. SHA-1 Checksums for profiles directly from the downloaded ZIP do not match the ones that were restored via X-Rite version 2.53. This is the result that I got on my 16IAX7. There is an announcement posted on Legion Series Discord precisely about this and it seems that it's true. This is the script that is ran on downloaded profiles:
So there is also |
Another finding is the X-Rite logs that contain definite proof of alterations:
So unless someone can figure out what happens really, I don't see how this can be added to LLT. |
Ouch. Too bad they went this way, instead of updating icms in the cloud... |
For what it's worth, you can install the profiles manually, and still be able to run X-Rite Color Assistant 2.53 to apply the transformations/patches to the profiles. The patching even works offline. |
It's offtop i guess, but since i can't make XRite to restore profiles, how do i trigger patching offline, if i have icm files? I tried the script, tried switching between now-installed profiles - no |
I would try looking into the log files of X-Rite to see why it's not restoring. Thread you linked is from 2 years ago, and X-Rite had a big update couple months back. |
I just opened xrite binaries in ghidra and |
Let's keep the conversation here about facts. Respectfully, we don't need to know about every thing that you do. Otherwise it will quickly spiral into off topic and will be difficult to follow. |
Make sure X-Rite 2.53 is installed: https://downloads.xrite.com/Downloads/Software/XRiteColorAssistant/Lenovo/v2.53.0/XRiteColorAssistantSetup.exe If there's no UAC prompt or the patches aren't named differently, that's weird 🤷♂️ |
Thank you, it worked. Interesting bit: for some profiles log has Relevant log if someone is interested
|
Just a side note, I own Legion 5 Pro with 5800H and even though X-Rite profiler is not officially supported, I've installed it and it found a profile for my display and installed it without issues. But when I compare it to my own profile (I've bought X-Rite Color Munki very cheap) it is totally different and I can't say I like those predefined profiles. sRGB is too yellow compared to anything around me like ASUS OLED, Macbook Pro/Air etc.. so I stick with my custom profile, still 6500K but much less yellowish tint |
This could be a bit off-topic, but I am trying to troubleshoot the same problem. Could you provide more details on how to use XRite to patch the ICC files? I have the same model as you, and here is what I did. I downloaded the zip file from Lenovo API. The dates are mixed: both 2023 and 2030. I modified the dates to 202201010000 for all icm files, in order for XRite to recognize them, and copied them (five files) to "C:\Windows\System32\spool\drivers\color". I installed x-rite 2.53, opened it, and then manually selected each file. But from the log file, no patch was applied. I can't find entries with "TRACE ProfileModifier" that are similar to what you provided. Based on the sha512 hash of the files, nothing has changed... |
that's what i did exactly:
PS glad that i'm not the only owner of this laptop model looking for answers |
Version
2.24.1
OS
Windows 10 22H2
Device
Legion Pro 7 16ARX8H
Is your feature request related to a problem?
My laptop comes with a color-calibrated LCD panel. Lenovo offers
X-Rite Color Assistant
app which should download and install profiles for a given panel, but the app is finicky and doesn't work for everyone.Calibration profiles are zipped, X-Rite tries to download them but
For more details and other user reports you can check this thread: https://forums.lenovo.com/t5/ThinkPad-P-and-W-Series-Mobile-Workstations/X-Rite-Color-Assistant-fails-to-restore-color-profiles/m-p/5159754
I guess Lenovo does not provide these zips with
*.icm
files on download page for each laptop model, because they are unique for each panel, so you need a serial number, not just machine type.People found out what X-Rite does:
*.icm
profiles%WINDIR%\System32\spool\drivers\color
So it's feasible to implement in LLT as it's a perfect Vantage/SystemUpdate replacement :)
Here's a Powershell implementation of zip retrieval:
I didn't look for a way to actually bind profiles to a monitor though, that turned out to be pretty straightforward to do manually in native
Color management
tool.How would you like the problem to be solved?
Add a feature to LLT to download and install color calibration profiles for laptop's LCD panel
What alternatives have you considered?
X-Rite Color Assistant app offered by Lenovo support page doesn't work for everyone and is really not needed as people figured out how it works
Additional information
If you don't have hardware which comes with color profiles and X-Rite, i can help with testing and/or share my serial to debug URL construction logic
The text was updated successfully, but these errors were encountered: