Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the noToken option for retrieving books to implicit #126

Open
duncangrubbs opened this issue Jul 8, 2020 · 0 comments
Open

Move the noToken option for retrieving books to implicit #126

duncangrubbs opened this issue Jul 8, 2020 · 0 comments
Labels
enhancement New feature or request general General issue with the project

Comments

@duncangrubbs
Copy link
Member

Currently, we have an endpoint for getting books without a token (getBooksNoToken/) as well as an endpoint for getting them when you are logged in (with a token, getAllBooks/). Instead, we should move to one endpoint that uses auth.optional, and if a token is provided, then we can block the user's books from showing up, etc. and if not, then it just functions as getBooksNoToken
@duncangrubbs duncangrubbs added enhancement New feature or request general General issue with the project labels Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request general General issue with the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@duncangrubbs