Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully working wallet daemon and client [$7,500 BOUNTY!] #66

Open
BlueSilver22 opened this issue Sep 3, 2018 · 7 comments
Open

Fully working wallet daemon and client [$7,500 BOUNTY!] #66

BlueSilver22 opened this issue Sep 3, 2018 · 7 comments

Comments

@BlueSilver22
Copy link
Contributor

BlueSilver22 commented Sep 3, 2018

The rebase is almost finished, however, there are still various issues to be worked out. More manpower is needed to ensure we have a fully working wallet with all passing tests that works for shielded and transparent transactions.

There is a $7500 bounty on this issue.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@BlueSilver22 BlueSilver22 changed the title Fully working wallet daemon and client Fully working wallet daemon and client [$5000] Sep 3, 2018
@BlueSilver22 BlueSilver22 added the bounty bounty label Sep 3, 2018
@BlueSilver22 BlueSilver22 changed the title Fully working wallet daemon and client [$5000] Fully working wallet daemon and client Sep 3, 2018
@BlueSilver22 BlueSilver22 removed the bounty bounty label Sep 3, 2018
@Donneker
Copy link

Donneker commented Sep 4, 2018

Can you be more clear about what exactly should be done here? It is absolutly not clear for myself. Can you specify the wallet in question and list all the issues that should be solved?
For someone not directly involved its hardly possible to get a picture.

@CCob
Copy link

CCob commented Sep 8, 2018

I'd be happy to take on some of this, but how are you managing duplicate work by other contributors etc...? Are you breaking down each unit of work into an issue that can be assigned to a particular developer? I can see the remaining issues have various bounties but they don't appear to mount up to the $5000 bounty on this issue. Thanks

@BlueSilver22
Copy link
Contributor Author

@Donneker it involves the wallet RPC calls and ensuring the wallet works properly.

@CCob please join our discord and use the development channels if you haven’t already: https://discord.gg/3Wph6sE

@mattpass mattpass changed the title Fully working wallet daemon and client Fully working wallet daemon and client [$5,000 BOUNTY!] Sep 13, 2018
@mattpass mattpass changed the title Fully working wallet daemon and client [$5,000 BOUNTY!] Fully working wallet daemon and client [$7,500 BOUNTY!] Sep 13, 2018
@mattpass
Copy link

mattpass commented Oct 5, 2018

Below is a list of RPC calls from latest Bitcoin codebase, taken from https://bitcoin.org/en/developer-reference#rpcs.

It would be very useful to have people check these off as they're confirmed as fully working...

  • AbandonTransaction
  • AddMultiSigAddress
  • AddNode
  • AddWitnessAddress
  • BackupWallet
  • BumpFee
  • ClearBanned
  • CreateMultiSig
  • CreateRawTransaction
  • DecodeRawTransaction
  • DecodeScript
  • DisconnectNode
  • DumpPrivKey
  • DumpWallet
  • EncryptWallet
  • EstimateFee
  • EstimatePriority
  • FundRawTransaction
  • Generate
  • GenerateToAddress
  • GetAccountAddress
  • GetAccount
  • GetAddedNodeInfo
  • GetAddressesByAccount
  • GetBalance
  • GetBestBlockHash
  • GetBlock
  • GetBlockChainInfo
  • GetBlockCount
  • GetBlockHash
  • GetBlockHeader
  • GetBlockTemplate
  • GetChainTips
  • GetConnectionCount
  • GetDifficulty
  • GetGenerate
  • GetHashesPerSec
  • GetInfo
  • GetMemoryInfo
  • GetMemPoolAncestors
  • GetMemPoolDescendants
  • GetMemPoolEntry
  • GetMemPoolInfo
  • GetMiningInfo
  • GetNetTotals
  • GetNetworkHashPS
  • GetNetworkInfo
  • GetNewAddress
  • GetPeerInfo
  • GetRawChangeAddress
  • GetRawMemPool
  • GetRawTransaction
  • GetReceivedByAccount
  • GetReceivedByAddress
  • GetTransaction
  • GetTxOut
  • GetTxOutProof
  • GetTxOutSetInfo
  • GetUnconfirmedBalance
  • GetWalletInfo
  • GetWork
  • Help
  • ImportAddress
  • ImportMulti
  • ImportPrivKey
  • ImportPrunedFunds
  • ImportWallet
  • KeyPoolRefill
  • ListAccounts
  • ListAddressGroupings
  • ListBanned
  • ListLockUnspent
  • ListReceivedByAccount
  • ListReceivedByAddress
  • ListSinceBlock
  • ListTransactions
  • ListUnspent
  • LockUnspent
  • Move
  • Ping
  • PreciousBlock
  • PrioritiseTransaction
  • PruneBlockChain
  • RemovePrunedFunds
  • SendFrom
  • SendMany
  • SendRawTransaction
  • SendToAddress
  • SetAccount
  • SetBan
  • SetGenerate
  • SetNetworkActive
  • SetTxFee
  • SignMessage
  • SignMessageWithPrivKey
  • SignRawTransaction
  • Stop
  • SubmitBlock
  • ValidateAddress
  • VerifyChain
  • VerifyMessage
  • VerifyTxOutProof
  • WalletLock
  • WalletPassphrase
  • WalletPassphraseChange

@mattpass
Copy link

Reminder for the future re this comment:
5b682bf#r30912654

@mattpass
Copy link

I've set up https://testnet.btcprivate.org/ and https://regtest.btcprivate.org and got a lot of people testing commands as much as possible, had various dev calls, created working examples and we're now at 111/119 Bitcoin RPC methods passing, with the rest provably working in the next few days.

@mattpass
Copy link

Next steps are to get z methods setup and testable so we can see what doesn't work from those. The standard tests in the test dir also need tweaking as noted on other issues so they all pass as expected.

The UI and much dev testing via the CLI proves all works as expected, it's simply a case of adjusting the tests where necessary to run a BTCP focused command (eg some fail due to BTC address etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@mattpass @Donneker @CCob @BlueSilver22 and others