Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AA mutation calling module #41

Open
jpalmer37 opened this issue Sep 11, 2024 · 1 comment · May be fixed by #42
Open

Update AA mutation calling module #41

jpalmer37 opened this issue Sep 11, 2024 · 1 comment · May be fixed by #42

Comments

@jpalmer37
Copy link
Collaborator

The AA mutation calling module is in need of an upgrade to improve its formatting, simplicity, and start-position logic. The following changes will be implemented:

  • integrating the BLASTX search into the Python script itself, to remove a required argument
  • changing the script logic to utilize BLASTX start positions for reliability
  • fixing title headers in the output TSV
  • updating the BLASTX database as the start positions of certain segments (HA) are incorrect
@jpalmer37 jpalmer37 linked a pull request Sep 11, 2024 that will close this issue
Open
@jpalmer37
Copy link
Collaborator Author

This was deemed not necessary. Original logic was already quite robust.

  • changing the script logic to utilize BLASTX start positions for reliability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update snp calling module BCCDC-PHL/fluviewer-nf
1 participant
@jpalmer37