-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature#19 disabling employees #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertVel666
requested review from
EusebioAjas,
anxhe,
Arkamis and
SpidySamurai
and removed request for
EusebioAjas
April 29, 2021 18:16
Closed
RobertVel666
force-pushed
the
feature#19_disabling_employees
branch
from
April 29, 2021 19:00
3203579
to
88c734b
Compare
anxhe
requested review from
ALAN1MACIAS,
AleysRocaVargas,
Brayan9105,
brayandiazc,
Carlos-Montiel,
cfcortes,
facundotoconas,
JorgeDDW,
Magic-Kowel,
marianoalarcon and
Martin11-RL
April 30, 2021 00:40
RobertVel666
force-pushed
the
feature#19_disabling_employees
branch
from
April 30, 2021 17:40
88c734b
to
7483a4b
Compare
anxhe
force-pushed
the
feature#19_disabling_employees
branch
from
April 30, 2021 20:47
403d500
to
5c557d8
Compare
Co-authored-by: EusebioAjas <[email protected]> Co-authored-by: Anxhe <[email protected]> Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]> Co-authored-by: Anxhe <[email protected]> Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]> Co-authored-by: Anxhe <[email protected]> Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]> Co-authored-by: Anxhe <[email protected]> Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: RobertVel666 <[email protected]> Co-authored-by: SpidySamurai <[email protected]> Co-authored-by: Anxhe <[email protected]>
replace update for toggle method Co-authored-by: RobertVel666 <[email protected]> Co-authored-by: SpidySamurai <[email protected]> Co-authored-by: Anxhe <[email protected]>
Co-authored-by: RobertVel666 <[email protected]> Co-authored-by: SpidySamurai <[email protected]> Co-authored-by: Anxhe <[email protected]>
Co-authored-by: EusebioAjas <[email protected]> Co-authored-by: Anxhe <[email protected]> Co-authored-by: SpidySamurai <[email protected]>
- With this change wdm would only be installed in: - %i[mingw mswin x64_mingw jruby] - When running bundle install on Mac Gemfile.lock won't be updated Co-authored-by: RobertVel666 <[email protected]> Co-authored-by: SpidySamurai <[email protected]> Co-authored-by: EusebioAjas <[email protected]>
anxhe
force-pushed
the
feature#19_disabling_employees
branch
from
April 30, 2021 21:07
5c557d8
to
32e3ef0
Compare
- when employee is disabled or enabled. - when a error success to save employee is rescue. - When a error sucess in the validates is rescue. Co-authored-by: RobertVel666 <[email protected]> Co-authored-by: SpidySamurai <[email protected]> Co-authored-by: EusebioAjas <[email protected]>
anxhe
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job teem , we can now enjoy the weekend
EusebioAjas
approved these changes
May 1, 2021
Open
2 tasks
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Employees can change there state:
Testing
After cloning the repository run on the terminal in the repository directory:
Enter the URL (e.g.: http://127.0.0.1:3000) that rails server is listening on in your navigator.
User: [email protected]
Password: password
Press the show button of any company branch.
Now you can manage your employees..
Screenshots
Walkthrough