Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature#19 disabling employees #30

Merged
merged 10 commits into from
May 1, 2021
Merged

Conversation

RobertVel666
Copy link
Contributor

Description

Employees can change there state:

  • Through an input you can disable and enable an employees status. This was implemented to know an employees current activity status. You can visualize the state from the employees table and in its own show view.

Testing

After cloning the repository run on the terminal in the repository directory:

yarn install
bundle install
rails db:setup
rails db:seed
rails server

Enter the URL (e.g.: http://127.0.0.1:3000) that rails server is listening on in your navigator.
User: [email protected]
Password: password
Press the show button of any company branch.
Now you can manage your employees..

Screenshots

Walkthrough

employee_enable_button

@RobertVel666 RobertVel666 requested review from EusebioAjas, anxhe, Arkamis and SpidySamurai and removed request for EusebioAjas April 29, 2021 18:16
@RobertVel666 RobertVel666 added this to the Sprint 4 milestone Apr 29, 2021
@RobertVel666 RobertVel666 linked an issue Apr 29, 2021 that may be closed by this pull request
@RobertVel666 RobertVel666 force-pushed the feature#19_disabling_employees branch from 3203579 to 88c734b Compare April 29, 2021 19:00
@RobertVel666 RobertVel666 force-pushed the feature#19_disabling_employees branch from 88c734b to 7483a4b Compare April 30, 2021 17:40
@anxhe anxhe force-pushed the feature#19_disabling_employees branch from 403d500 to 5c557d8 Compare April 30, 2021 20:47
RobertVel666 and others added 5 commits April 30, 2021 23:03
Co-authored-by: EusebioAjas <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: RobertVel666 <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: Anxhe <[email protected]>
EusebioAjas and others added 4 commits April 30, 2021 23:03
replace update for toggle method

Co-authored-by: RobertVel666 <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: RobertVel666 <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
Co-authored-by: Anxhe <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
 - With this change wdm would only be installed in:
   - %i[mingw mswin x64_mingw jruby]
 - When running bundle install on Mac Gemfile.lock won't be updated

Co-authored-by: RobertVel666 <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
@anxhe anxhe force-pushed the feature#19_disabling_employees branch from 5c557d8 to 32e3ef0 Compare April 30, 2021 21:07
- when employee is disabled or enabled.
- when a error success to save employee is rescue.
- When a error sucess in the validates is rescue.

Co-authored-by: RobertVel666 <[email protected]>
Co-authored-by: SpidySamurai <[email protected]>
Co-authored-by: EusebioAjas <[email protected]>
Copy link
Contributor

@anxhe anxhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job teem , we can now enjoy the weekend

@RobertVel666 RobertVel666 merged commit 6d3a355 into master May 1, 2021
@RobertVel666 RobertVel666 deleted the feature#19_disabling_employees branch May 1, 2021 00:55
@cfcortes cfcortes linked an issue Jun 28, 2021 that may be closed by this pull request
2 tasks
@cfcortes cfcortes removed a link to an issue Jun 28, 2021
2 tasks
@cfcortes cfcortes linked an issue Jun 28, 2021 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example 3 Disabling employees
3 participants