Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for the Route entity must be set on the create/insert handler as the server has all the information needed to do so #48

Open
panchoh opened this issue Oct 22, 2019 · 3 comments
Labels
discussion things to discuss about Windows-support
Milestone

Comments

@panchoh
Copy link
Contributor

panchoh commented Oct 22, 2019

// TODO: Add default values for flags and remove path flag

@panchoh panchoh added this to the 1.0.0 milestone Oct 22, 2019
@panchoh panchoh added the question Further information is requested label Oct 22, 2019
@panchoh panchoh changed the title REVIEW: cmd/route: add default values for flags and remove path flag cmd/route: add default values for flags and remove path flag Oct 22, 2019
@hhurtado hhurtado added Windows-support and removed question Further information is requested labels Oct 22, 2019
@panchoh panchoh modified the milestones: 1.0.0, 1.1.0 Oct 23, 2019
@panchoh
Copy link
Contributor Author

panchoh commented Oct 23, 2019

@hhurtado suggest also that the server should provide some form of validation. We should create a ticket for that, to be discussed.

@panchoh panchoh added discussion things to discuss about and removed discussion things to discuss about labels Oct 23, 2019
@panchoh panchoh changed the title cmd/route: add default values for flags and remove path flag cmd/route: set default values for flags in server/control/api Oct 23, 2019
@panchoh panchoh added the discussion things to discuss about label Oct 31, 2019
@panchoh
Copy link
Contributor Author

panchoh commented Oct 31, 2019

Duplicate of #37. Will continue here, since we have more context now.

@hhurtado dixit:

The default values for the Route entity must be set on the create/insert handler as the server has all the information needed to do so

@hhurtado hhurtado changed the title cmd/route: set default values for flags in server/control/api Default values for the Route entity must be set on the create/insert handler as the server has all the information needed to do so Aug 24, 2020
@hhurtado
Copy link
Contributor

Rewrite Issue tittle. The task is to move the default values from the cmd module to the server/control module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion things to discuss about Windows-support
Projects
None yet
Development

No branches or pull requests

2 participants