Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure some time scales and coordinate origins are correct #131

Merged
merged 3 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ lint = { composite = [
"black --check ./src/adam_core",
"isort --check-only ./src/adam_core",
] }
fix = "ruff ./src/adam_core --fix"
fix = "ruff check ./src/adam_core --fix"
typecheck = "mypy --strict ./src/adam_core"

test = "pytest --benchmark-skip -m 'not profile' {args}"
Expand Down
5 changes: 3 additions & 2 deletions src/adam_core/dynamics/propagation.py
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,9 @@ def propagate_2body(
else:
cartesian_covariances = None

origin_code = np.empty(n_orbits * n_times, dtype="object")
origin_code.fill("SUN")
origin_code = np.repeat(
orbits.coordinates.origin.code.to_numpy(zero_copy_only=False), n_times
)

# Convert from the jax array to a numpy array
orbits_propagated = np.asarray(orbits_propagated)
Expand Down
15 changes: 11 additions & 4 deletions src/adam_core/propagator/propagator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging
from abc import ABC, abstractmethod
from typing import List, Literal, Optional, Type, Union
from typing import List, Literal, Optional, Tuple, Type, Union

import numpy as np
import numpy.typing as npt
Expand Down Expand Up @@ -103,7 +103,7 @@ def _add_light_time(
observers,
lt_tol: float = 1e-12,
max_iter: int = 10,
):
) -> Tuple[Orbits, np.ndarray]:
orbits_aberrated = Orbits.empty()
lts = np.zeros(len(orbits))
for i, (orbit, observer) in enumerate(zip(orbits, observers)):
Expand Down Expand Up @@ -433,8 +433,8 @@ def _propagate_orbits(self, orbits: OrbitType, times: TimestampType) -> OrbitTyp

def propagate_orbits(
self,
orbits: OrbitType,
times: TimestampType,
orbits: Union[OrbitType, ObjectRef],
times: Union[TimestampType, ObjectRef],
covariance: bool = False,
covariance_method: Literal[
"auto", "sigma-point", "monte-carlo"
Expand Down Expand Up @@ -495,6 +495,7 @@ def propagate_orbits(
times_ref = ray.put(times)
else:
times_ref = times
times = ray.get(times_ref)

if not isinstance(orbits, ObjectRef):
orbits_ref = ray.put(orbits)
Expand Down Expand Up @@ -574,6 +575,12 @@ def propagate_orbits(
if propagated_variants is not None:
propagated = propagated_variants.collapse(propagated)

# Preserve the time scale of the requested times
propagated = propagated.set_column(
"coordinates.time",
propagated.coordinates.time.rescale(times.scale),
)

# Return the results with the original origin and frame
# Preserve the original output origin for the input orbits
# by orbit id
Expand Down
2 changes: 0 additions & 2 deletions src/adam_core/propagator/tests/test_propagator.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import numpy as np
import pyarrow as pa
import pytest
import quivr as qv

from ...coordinates.cartesian import CartesianCoordinates
Expand Down Expand Up @@ -90,7 +89,6 @@ def test_propagator_single_worker():
pass


@pytest.mark.skipif(RAY_INSTALLED is False, reason="Ray is not installed.")
def test_propagator_multiple_workers_ray():
orbits = make_real_orbits(10)
times = Timestamp.from_iso8601(["2020-01-01T00:00:00", "2020-01-01T00:00:01"])
Expand Down
Loading