Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ADES utility #109

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add ADES utility #109

merged 2 commits into from
Jul 9, 2024

Conversation

moeyensj
Copy link
Member

@moeyensj moeyensj commented May 6, 2024

The included sample_ades.psv (which the ADES utility is tested against) passes the Minor Planet Center's ADES submission test:

curl https://minorplanetcenter.net/submit_psv_test -F "ack=TEST" -F "[email protected]" -F "source=<sample_ades.psv"
Submission format valid.

@moeyensj moeyensj changed the base branch from main to jm/update-test-data May 6, 2024 20:44
Base automatically changed from jm/update-test-data to main May 6, 2024 21:13
@moeyensj moeyensj requested a review from akoumjian May 7, 2024 18:27
akoumjian
akoumjian approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@akoumjian akoumjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions and comments.

adam_core/observations/ades.py Outdated Show resolved Hide resolved
adam_core/observations/ades.py Outdated Show resolved Hide resolved
adam_core/observations/ades.py Outdated Show resolved Hide resolved
adam_core/observations/tests/test_ades.py Outdated Show resolved Hide resolved
@moeyensj
Copy link
Member Author

moeyensj commented Jul 9, 2024

@akoumjian Ready for a second look. Turns out you can use df.to_csv() to output directly to a string.

@akoumjian
Copy link
Contributor

:shipit:

@moeyensj moeyensj merged commit 7f7fcd5 into main Jul 9, 2024
3 checks passed
@moeyensj moeyensj deleted the jm/ades branch July 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoumjian akoumjian akoumjian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moeyensj @akoumjian