Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public api DefaultCredentialsLoader.LoadFirstValidCredentialsAsync fails when the first credential can't load #3021

Open
bgavrilMS opened this issue Sep 19, 2024 · 4 comments
Assignees
Labels
bug Something isn't working P2

Comments

@bgavrilMS
Copy link
Member

bgavrilMS commented Sep 19, 2024

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

3.10

Description

  1. Create a list of CredentialDescription with 2 credentials, e.g. a certificate from a non-existent file and a certificate from string. Ensure the first credential fails.
  2. Call the public API DefaultCredentialsLoader.LoadFirstValidCredentialsAsync(list)

Expected: log first credential failure as information, and proceed to use the second credential
Actual: an exception is thrown, from the first credential failure

Reproduction steps

^^

Error message

No response

Id Web logs

No response

Relevant code snippets

LoadFirstValidCredentialsAsync

Regression

No response

Expected behavior

no exception

@bgavrilMS bgavrilMS changed the title Public api DefaultCredentialsLoader.LoadFirstValidCredentialsAsync fails on first failure Public api DefaultCredentialsLoader.LoadFirstValidCredentialsAsync fails when the first credential can't load Sep 22, 2024
@jmprieur
Copy link
Collaborator

Is it a regression?

@bgavrilMS
Copy link
Member Author

bgavrilMS commented Sep 25, 2024

No, I don't think so. It like that from day 1.

@jennyf19
Copy link
Collaborator

Are you expecting my team to pick this up?

@bgavrilMS bgavrilMS self-assigned this Sep 26, 2024
@bgavrilMS
Copy link
Member Author

Looks like a good first issue for someone from MSAL team to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

No branches or pull requests

3 participants