Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change detection for generated Swift API #1891

Open
macdrevx opened this issue Oct 6, 2023 · 0 comments
Open

Breaking change detection for generated Swift API #1891

macdrevx opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels

Comments

@macdrevx
Copy link

macdrevx commented Oct 6, 2023

Prior to #1639, you could refer to MSALInternalErrorAuthorizationFailed from Swift via MSALInternalError.errorAuthorizationFailed. The PR added some new cases that started with the prefix MSALError instead of MSALInternalError and that seems to have changed how the pre-existing cases are imported into Swift such that you now have to write: MSALInternalError.internalErrorAuthorizationFailed.

There's also MSALInternalBrokerNotAvailable which lacks the full prefix. I suspect that if all the cases used the full MSALInternalError prefix, then in Swift you could write MSALInternalError.authorizationFailed.

It's not hard for developers to update their code accordingly when updating, but these issues do lead to source-breaking changes.

To detect these issues earlier, it would be good to set up automated breaking change detection for the generated Swift API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants