Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resource group dependencies #358

Open
kewalaka opened this issue Apr 13, 2024 · 3 comments · May be fixed by #371
Open

feat: resource group dependencies #358

kewalaka opened this issue Apr 13, 2024 · 3 comments · May be fixed by #371
Assignees
Labels
enhancement New feature or request PR: Referenced 👀 Issue is referenced in a PR Type: Enhancement ✨ New feature or request

Comments

@kewalaka
Copy link
Contributor

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Consider the scenario where the module is used to create resource group, with the intention these are used by components such as umi's and vnets.

This can be almost be accomplished by setting the resource_group_creation_enabled flag and passing in the name of the RG, except there is no dependency in place between these resources and the RG module, and thus it can fail.

Q. Is this approach valid, are we at risk of introducing unnecessary dependencies?

Describe the solution you'd like

Proposal is to add dependencies on the RG module. It would also be good to add the RGs to the outputs so components external to the module can make use of them.

Currently I create the resource groups outside the LZ module.

Additional context

@matt-FFFFFF
Copy link
Member

Hi @kewalaka

At the moment the submodule create their own RGs, e.g. vnet/umi.

Is there another scenario that you would like?

@matt-FFFFFF matt-FFFFFF self-assigned this Apr 25, 2024
@matt-FFFFFF matt-FFFFFF added enhancement New feature or request Type: Enhancement ✨ New feature or request labels Apr 25, 2024
@kewalaka kewalaka linked a pull request Apr 25, 2024 that will close this issue
5 tasks
@kewalaka
Copy link
Contributor Author

@matt-FFFFFF just illustrated what i'm looking to accomplish with PR #371

@kewalaka
Copy link
Contributor Author

kewalaka commented Oct 7, 2024

hi @matt-FFFFFF - i didn't directly answer your question but it is in the PR linked above, namely the scenario is to have a single RG for LZ resources such as the vnet/umi rather than a separate one for each. Especially when doing "resource group vending" - having so many small-scoped RGs becomes a bit overwhelming.

The use case is illustrated on #371

Unless i'm missing something this looks like a reasonable non-contentious one to land (famous last words 😅)

@microsoft-github-policy-service microsoft-github-policy-service bot added the PR: Referenced 👀 Issue is referenced in a PR label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: Referenced 👀 Issue is referenced in a PR Type: Enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants