Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node Labels #108

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add Node Labels #108

merged 1 commit into from
Sep 13, 2024

Conversation

zioproto
Copy link
Collaborator

Description

Adds Node Labels to all nodepools.

Closes #106

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Sep 11, 2024
@zioproto zioproto mentioned this pull request Sep 11, 2024
Closed
1 task
@zioproto zioproto requested a review from nellyk September 11, 2024 12:20
nellyk
nellyk reviewed Sep 11, 2024
View reviewed changes
main.tf Show resolved Hide resolved
zioproto
zioproto commented Sep 13, 2024
View reviewed changes
main.tf
@@ -76,6 +77,7 @@ resource "azurerm_kubernetes_cluster" "this" {
## Resources that only support UserAssigned
dynamic "identity" {
for_each = local.managed_identities.user_assigned

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is here because we did not merge PR #105 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehehe strange

@nellyk nellyk mentioned this pull request Sep 13, 2024
Closed
1 task
@nellyk nellyk merged commit a498044 into main Sep 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nellyk nellyk nellyk approved these changes

Assignees
No one assigned
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: add node_labels to default_node_pool and azurerm_kubernetes_cluster_node_pool
2 participants
@zioproto @nellyk