Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to azurerm provider version 4 #137

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to azurerm provider version 4 #137

wants to merge 4 commits into from

Conversation

zioproto
Copy link
Collaborator

Description

Upgrade to azurerm provider version 4

Fixes #128
Closes #128

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 31, 2024
zioproto
zioproto commented Oct 31, 2024
View reviewed changes
main.tf Outdated
version = "0.3.1"
for_each = toset(var.acr == null ? [] : ["acr"])
# point to https://github.com/zioproto/terraform-azurerm-avm-res-containerregistry-registry/tree/provider-v4
source = "github.com/zioproto/terraform-azurerm-avm-res-containerregistry-registry?ref=provider-v4"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed before merging.
It requires this PR to be merged:
Azure/terraform-azurerm-avm-res-containerregistry-registry#95

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zioproto, that PR is merged so maybe this PR can be included soon? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasehlert I know the PR is merged. I am waiting for the 0.4.0 release of terraform-azurerm-avm-res-containerregistry-registry

@zioproto zioproto mentioned this pull request Oct 31, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasehlert tobiasehlert tobiasehlert left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs: Triage 🔍 Maintainers need to triage still
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: provider v4.0
2 participants
@zioproto @tobiasehlert