Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Improve/Enhance guidance around what a good example of a module is #22

Open
jtracey93 opened this issue Mar 8, 2023 · 1 comment
Labels
feature new functionality for existing module

Comments

@jtracey93
Copy link
Contributor

Module Name

N/A

Description

From my review of the codex I think it does a great job at covering the composition of the code and tests required for a module but it doesnt really go into the "what a good/bad module is" at a higher level?

For example, we have discussed with @grayzu that resource wrapping single resources is not a great approach and adds little value in most scenarios, think like a module for a resource group or a public IP. On their own these as modules add little value, but as part of something like a Hub Networking module that wraps creating a VNet, Firewall (with Public IP), VPN/ER Gateways etc. then thats much more valuable.

Therefore I think it could be useful for contributors and consumers of these modules to see this more explicitly defined and called out in the codex in this repo. I know there is a link to the hashicorp docs, on a very similar topic in the main codex overview page, but I fear folks won't click through to it (plus its a little open ended and not opinionated)

Example usage

No response

Other information

No response

@jtracey93 jtracey93 added the feature new functionality for existing module label Mar 8, 2023
@zioproto
Copy link
Contributor

@jtracey93 I actively contribute to the AKS module that is mostly all about the azurerm_kubernetes_cluster resource.
However the resource is super complex to configure, and having the module enforcing reasonable defaults and avoiding conflicting options is already an added value.
Users also appreciate the end to end tests so that when a piece of configuration is added to the module, we know it is covered by the end to end tests, and this avoids breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality for existing module
Projects
None yet
Development

No branches or pull requests

2 participants