Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ISO-8859-1 to encode proxy requests #42

Open
2 tasks
conniey opened this issue May 13, 2021 · 3 comments
Open
2 tasks

Use ISO-8859-1 to encode proxy requests #42

conniey opened this issue May 13, 2021 · 3 comments
Assignees
@SivaTharun
Labels
good first issue Good for newcomers up-for-grabs

Comments

@conniey
Copy link
Member

conniey commented May 13, 2021 •
edited
Loading

We use request.getBytes() to get the bytes for the proxy request.

  • Create another method in ProxyHandler.createProxyRequest to return bytes[] rather than a String.
    • I believe the createProxyRequest is already shipped, so we don't want to break existing users.
    • Encode bytes[] as ISO-8859-1
  • Remove spotbugs suppression:
@conniey conniey mentioned this issue May 13, 2021
Merged
@SivaTharun
Copy link
Contributor

@conniey can i work on this issue.

@conniey
Copy link
Member Author

conniey commented May 17, 2021

@SivaTharun Wow! Thanks so much. :) One of the weird things about this is testing because encodings are a bit of a pain.

@SivaTharun SivaTharun mentioned this issue Jun 13, 2021
Open
@SivaTharun
Copy link
Contributor

@conniey can you review this PR, that i have raised to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SivaTharun SivaTharun

Labels
good first issue Good for newcomers up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conniey @SivaTharun