Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-deploy does not update pods with new images #314

Open
1 task done
Chris-Sheridan opened this issue Mar 9, 2024 · 1 comment
Open
1 task done

k8s-deploy does not update pods with new images #314

Chris-Sheridan opened this issue Mar 9, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Chris-Sheridan
Copy link

What happened?

This executes as part of my GH Actions after a code update. The resulting image builds fine and is uploaded to my ACR registry. GH Actions successfully runs k8s-deploy as part of the workflow, but it doesn't detect any changes. The pods never bleed over and the old pods still run. I'm sure I have something wrong but I've had no luck searching.

Here's my action...
- name: Deploy Cluster
uses: Azure/k8s-deploy@v4
with:
resource-group: $RESOURCE_GROUP
name: $NAME
action: deploy
strategy: basic
pull-images: false
namespace: ingress-basic
private-cluster: false
manifests: |
k8s/deployment.yaml
k8s/service.yaml
k8s/cluster-issuer.yaml
k8s/ingress.yaml
images: |
myacr.azurecr.io/my-app:latest

I appreciate any thoughts people have on what I'm missing.

Version

  • I am using the latest version

Runner

self-hosted, Azure ACA Container Job

Relevant log output

/usr/local/bin/kubectl apply -f /tmp/deployment.yaml,/tmp/service.yaml,/tmp/cluster-issuer.yaml,/tmp/ingress.yaml --namespace ingress-basic
deployment.apps/my-app unchanged
service/my-app unchanged
clusterissuer.cert-manager.io/letsencrypt unchanged
ingress.networking.k8s.io/my-app-ingress unchanged

@Chris-Sheridan Chris-Sheridan added the bug Something isn't working label Mar 9, 2024
@OrellBuehler
Copy link

If you use latest as the tag for all images and you don't set pull-images to true, then I believe it will use the cached images instead of updating them from your registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants