Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content of tags field within ModernReservationTransaction question #23804

Open
marianogappa opened this issue Nov 27, 2024 · 1 comment
Open
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Reservations Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@marianogappa
Copy link

Unlike most endpoints that return resources with tags fields as objects (which in the Go SDK are structured as map[string]*string), the ReservationTransactions list endpoint returns a []*string.

https://learn.microsoft.com/en-us/rest/api/consumption/reservation-transactions/list?view=rest-consumption-2024-08-01&tabs=HTTP#reservationtransaction

The docs describe it as:

Resource tags.

Image

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/consumption/armconsumption/reservationtransactions_client.go#L109

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/resourcemanager/consumption/armconsumption/models.go#L1527

// ModernReservationTransaction - Modern Reservation transaction resource.
type ModernReservationTransaction struct {
	// REQUIRED; The properties of a modern reservation transaction.
	Properties *ModernReservationTransactionProperties

	// READ-ONLY; Resource Id.
	ID *string

	// READ-ONLY; Resource name.
	Name *string

	// READ-ONLY; Resource tags.
	Tags []*string    // <- this field here

	// READ-ONLY; Resource type.
	Type *string
}

Could you provide examples for the value of this tags field? We'd want to understand it's structure. Is it a bag of random literal strings? Is it a list of key-value tuples, thus always being an even number of tags?

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Reservations Service Attention Workflow: This issue is responsible by Azure service team. labels Nov 27, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @rkapso.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Reservations Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

1 participant