add made required on value types

Azure · Nov 19, 2024 · b3f5221 · b3f5221
1 parent 39029a5
commit b3f5221
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 30 deletions.
diff --git a/...fication/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.KeyVault/KeyVault.tsp b/...fication/eventgrid/Azure.Messaging.EventGrid.SystemEvents/Microsoft.KeyVault/KeyVault.tsp
@@ -1,3 +1,5 @@
+import "@typespec/versioning";
+using TypeSpec.Versioning;
 /** Describes the schema of the Azure Key Vault events published to Azure Event Grid. This corresponds to the Data property of an EventGridEvent. */
 namespace Microsoft.EventGrid.SystemEvents {
   /** Schema of the Data property of an EventGridEvent for a Microsoft.KeyVault.CertificateNewVersionCreated event. */
@@ -72,10 +74,12 @@ namespace Microsoft.EventGrid.SystemEvents {
     Version: string;
 
     /** Not before date of the object that triggered this event */
+    @madeRequired(ServiceApiVersions.v2024_01_01)
     #suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
     NBF: float32;
 
     /** The expiration date of the object that triggered this event */
+    @madeRequired(ServiceApiVersions.v2024_01_01)
     #suppress "@azure-tools/typespec-azure-core/casing-style" "Modeling after service swagger."
     EXP: float32;
   };

diff --git a/...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json b/...ion/eventgrid/data-plane/Microsoft.EventGrid/stable/2018-01-01/GeneratedSystemEvents.json
@@ -5444,9 +5444,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultCertificateExpiredEventData": {
@@ -5489,9 +5487,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultCertificateNearExpiryEventData": {
@@ -5534,9 +5530,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultCertificateNewVersionCreatedEventData": {
@@ -5579,9 +5573,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultKeyExpiredEventData": {
@@ -5624,9 +5616,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultKeyNearExpiryEventData": {
@@ -5669,9 +5659,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultKeyNewVersionCreatedEventData": {
@@ -5714,9 +5702,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultSecretExpiredEventData": {
@@ -5759,9 +5745,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultSecretNearExpiryEventData": {
@@ -5804,9 +5788,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "KeyVaultSecretNewVersionCreatedEventData": {
@@ -5849,9 +5831,7 @@
         "VaultName",
         "ObjectType",
         "ObjectName",
-        "Version",
-        "NBF",
-        "EXP"
+        "Version"
       ]
     },
     "MachineLearningServicesDatasetDriftDetectedEventData": {