Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT compatiblity of SeedPromptDataset with send_prompt[s]_async #569

Open
romanlutz opened this issue Nov 19, 2024 · 0 comments
Open

FEAT compatiblity of SeedPromptDataset with send_prompt[s]_async #569

romanlutz opened this issue Nov 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@romanlutz
Copy link
Contributor

Is your feature request related to a problem? Please describe.

With our new SeedPrompt objects and SeedPromptDatasets there's an extra step required to plug them into the send methods which is painful.

Example:

adv_bench_prompts = fetch_adv_bench_dataset()
prompts = [prompt.value for prompt in adv_bench_prompts.prompts[:3]]
await orchestrator.send_prompts_async(prompt_list=prompts)  # type: ignore

Describe the solution you'd like

Instead of the middle step, there should either be
a) a way to plug in SeedPromptDatasets into send_prompts_async and the send method can extract the prompts from the dataset OR
b) there needs to be a simple access method, something like get_values() on the SeedPromptDataset class.

The latter seems a tad simpler.

Describe alternatives you've considered, if relevant

Additional context

@romanlutz romanlutz added the enhancement New feature or request label Nov 19, 2024
@romanlutz romanlutz changed the title FEAT FEAT compatiblity of SeedPromptDataset with send_prompt[s]_async Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant