-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC add setup instructions for MacOS and support macos-latest in CI #480
Comments
Are you using MacOS? Most of us use Windows and Ubuntu is used in the pipelines so they tend to work best. We should probably try and set up macOS pipelines at some point. Feel free to add extra info for macOS if I am indeed making correct assumptions. |
Yep, I am indeed using macOS. And okay, great, I'll go ahead and open a PR to add some more information. As far as setting up macOS pipelines, I think that it would require changing |
They run in parallel, shouldn't be a problem. The setup usually doesn't "just work", though. So there may be some work in getting the setup working on the build agent. You can give it a try if you like! |
To recap what needs to happen:
|
Describe the issue linked to the documentation
Hello! While running the tests for PyRIT locally with
make test-cov-xml
, I came across a few errors that resulted from aria2, pyodbc, and unixODBC not being installed locally. These errors do not appear in Actions since theubuntu-latest
image has these packages installed by default from what I believe (https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md).Suggest a potential alternative/fix
Perhaps we should add a note somewhere in the
doc/contributing
folder that Ubuntu is the intended environment for testing at the moment and that aria2, pyodbc, and unixODBC should be installed. I'd be happy to do so but would love to hear what everyone thinks first!The text was updated successfully, but these errors were encountered: