Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adf pipeline json #878

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: adf pipeline json #878

merged 1 commit into from
Nov 26, 2024
+286 −270

Conversation

ydaponte
Copy link
Contributor

Type of PR

  • Code changes

Purpose

  • correct the adf pipeline json with the correct databricks notebook path
  • remove unnecessary properties from previous REST API properties

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Deploying the solution and checking that the adf pipeline run with no issues

Issues Closed or Referenced

@ydaponte ydaponte added bug Something isn't working P0 Uber URGENT priority e2e: parking-sensors-databricks labels Nov 22, 2024
@ydaponte ydaponte self-assigned this Nov 22, 2024
thesqlpro
thesqlpro approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@thesqlpro thesqlpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ydaponte ydaponte merged commit 3d98de0 into feat/e2e-databricks-updates Nov 26, 2024
1 check passed
@ydaponte ydaponte deleted the ydaponte/remove-hard-coded-fork-reference branch November 26, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiliamLeme LiliamLeme LiliamLeme approved these changes

@thesqlpro thesqlpro thesqlpro approved these changes

Assignees

@ydaponte ydaponte

Labels
bug Something isn't working e2e: parking-sensors-databricks P0 Uber URGENT priority
Projects
None yet
Milestone
E2E - parking_sensor_databricks - V1
Development

Successfully merging this pull request may close these issues.
3 participants
@ydaponte @thesqlpro @LiliamLeme