From cd8166aee0be0668710a570e224421aa812aa29d Mon Sep 17 00:00:00 2001 From: Charlie Lye Date: Thu, 16 Mar 2023 09:55:13 +0000 Subject: [PATCH 1/3] Use new build context, cleaned up cci env vars. --- .circleci/config.yml | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d6833ac5c..bb8835d3f 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -38,11 +38,6 @@ checkout: &checkout chmod 0700 .ssh ssh-keyscan -t rsa github.com >> .ssh/known_hosts - # A read only key for cloning the repository. - echo $GIT_CHECKOUT_KEY | base64 -d > .ssh/id_rsa - - chmod 0600 .ssh/id_rsa - # IF YOU'RE CHANGING THIS, YOU ALSO WANT TO CHANGE: build-system/remote_build/remote_build # Shallow checkout this commit. mkdir -p project @@ -700,21 +695,24 @@ jobs: # Repeatable config for defining the workflow below. tag_regex: &tag_regex /v[0-9]+(\.[0-9]+)*(-[a-zA-Z-]+\.[0-9]+)?/ -tag_filter: &tag_filter - tags: - only: *tag_regex +defaults: &defaults + filters: + tags: + only: *tag_regex + context: + - build ac_test: &ac_test requires: - x86_64-linux-clang-assert - filters: *tag_filter + <<: *defaults yarn_project: &yarn_project requires: - yarn-project-base - filters: *tag_filter + <<: *defaults e2e_test: &e2e_test requires: - e2e-join - filters: *tag_filter + <<: *defaults deploy_filters: &deploy_filters branches: only: @@ -729,13 +727,13 @@ workflows: equal: [system, << pipeline.parameters.workflow >>] jobs: - wasm-linux-clang: - filters: *tag_filter + <<: *defaults - x86_64-linux-clang: - filters: *tag_filter + <<: *defaults - x86_64-linux-clang-assert: - filters: *tag_filter + <<: *defaults - x86_64-linux-gcc: - filters: *tag_filter + <<: *defaults - small-circuit-tests: *ac_test - tx-rollup-tests: *ac_test - tx-rollup-full-tests: *ac_test @@ -757,16 +755,16 @@ workflows: - blockchain-vks: requires: - x86_64-linux-clang - filters: *tag_filter + <<: *defaults - contracts: requires: - blockchain-vks - filters: *tag_filter + <<: *defaults - yarn-project-base: requires: - wasm-linux-clang - contracts - filters: *tag_filter + <<: *defaults - contracts-verifier-test: *yarn_project - barretenberg-js: *yarn_project - blockchain: *yarn_project @@ -788,7 +786,7 @@ workflows: - sdk - hummus - end-to-end - filters: *tag_filter + <<: *defaults - e2e-account: *e2e_test - e2e-browser: *e2e_test - e2e-chained-txs-with-spending-keys: *e2e_test From 603c3f4a566222241967cc8cf85abb8bcb1752e4 Mon Sep 17 00:00:00 2001 From: Charlie Lye Date: Thu, 16 Mar 2023 11:25:50 +0000 Subject: [PATCH 2/3] Fix deploy --- .circleci/config.yml | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bb8835d3f..a9df667c4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -713,13 +713,16 @@ e2e_test: &e2e_test requires: - e2e-join <<: *defaults -deploy_filters: &deploy_filters - branches: - only: - - master - - stage - tags: - only: *tag_regex +deploy_defaults: &deploy_defaults + filters: + branches: + only: + - master + - stage + tags: + only: *tag_regex + context: + - build workflows: system: @@ -812,7 +815,7 @@ workflows: - root-rollup-tests - root-rollup-full-tests - root-verifier-tests - filters: *deploy_filters + <<: *deploy_defaults - yarn-join: requires: - wallet @@ -822,7 +825,7 @@ workflows: - barretenberg-js - block-server - aztec-dev-cli - filters: *deploy_filters + <<: *deploy_defaults - deploy: requires: # Must list all projects at the end of a dependency chain. @@ -845,4 +848,4 @@ workflows: - e2e-virtual-assets - e2e-deposit-approval - int-rollup-processor - filters: *deploy_filters + <<: *deploy_defaults From 2251230dacf23170182f559eded7faeaf7aaa0a8 Mon Sep 17 00:00:00 2001 From: PhilWindle <60546371+PhilWindle@users.noreply.github.com> Date: Mon, 20 Mar 2023 09:43:59 +0000 Subject: [PATCH 3/3] Set the exit only flag on testnet and prod (#31) --- yarn-project/falafel/terraform/prod/main.tf | 2 +- yarn-project/falafel/terraform/testnet/main.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/yarn-project/falafel/terraform/prod/main.tf b/yarn-project/falafel/terraform/prod/main.tf index dab2530eb..7600d262e 100644 --- a/yarn-project/falafel/terraform/prod/main.tf +++ b/yarn-project/falafel/terraform/prod/main.tf @@ -241,7 +241,7 @@ resource "aws_ecs_task_definition" "falafel" { }, { "name": "EXIT_ONLY", - "value": "false" + "value": "true" } ], "mountPoints": [ diff --git a/yarn-project/falafel/terraform/testnet/main.tf b/yarn-project/falafel/terraform/testnet/main.tf index d41fd877d..a43d0ef51 100644 --- a/yarn-project/falafel/terraform/testnet/main.tf +++ b/yarn-project/falafel/terraform/testnet/main.tf @@ -241,7 +241,7 @@ resource "aws_ecs_task_definition" "falafel" { }, { "name": "EXIT_ONLY", - "value": "false" + "value": "true" } ], "mountPoints": [