Make the client compatible with AF 4.9. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r when the spans were customized.
console-framework-client/src/main/java/io/axoniq/console/framework/messaging/SpanMatcher.kt
Outdated
Show resolved
Hide resolved
CodeDrivenMitch
approved these changes
Oct 6, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the client compatible with 4.9, and also make it configurable for when the spans were customized.
Most work is done by the SpanMatcher enum, which provides an abstraction to determine, based on the name of the span, if the span factory should do certain things. This makes it both compatible with framework version before 4.9 as well as versions from 4.9.
It also adds an
createChildHandlerSpanoverwrite to the span factory in order to properly handle the 4.9 default way of setting the spans in a streaming event processor.It was tested with a gift card app, where all the messages show up. It might still miss things through.
It contains a few formatting changes, I'm not sure why through, as the
EditorConfigplugin is enabled.