You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue covers various findings on the current API design. An implementor(s) may group these findings into subtasks.
If possible rename bidi stream messages to: Platform(Inbound/Outbound)(Command/Query/Control)Instruction. Use instruction_id i.o. message_id.
common.proto
ErrorMessage -> rename location to source
FlowControl -> deprecate client_id
ErrorMessage -> introduce error_code as string
control.proto
ClientIdentification -> rename client_id to component_instance_id, rename component_name to component_id
SegmentStatus -> rename one_part_of to fraction
query.proto
QueryProviderInbound -> rename QueryRequestquery parameter to query_request
QueryRequest -> rename message_identifier to message_id, rename client_id to component_instance_id, rename component_name to component_id
QueryComplete -> remove message_id
QueryResponse -> rename message_identifier to message_id, deprecate error_code (since it'll be part of ErrorMessage), check whether processing_instruction is needed
SubscriptionQuery -> rename subscription_identifier to message_id, introduce SerializedType message as a copy of SerializedObject where 3 is reserved
QueryUpdate -> rename message_identifier to message_id, rename client_id to component_instance_id and component_name to component_id
QueryUpdateComplete -> rename client_id to component_instance_id and component_name to component_id, rename it to QueryUpdateCompleted
QueryUpdateCompleteExceptionally -> rename client_id to component_instance_id and component_name to component_id, rename to QueryUpdateCompletedExceptionally, deprecate error_code
SubscriptionQueryRequest -> reconsider current design - some field types could be adjusted
QuerySubscription -> rename query to query_name, rename result_name to result_type, rename client_id to component_instance_id and component_name to component_id
command.proto
Command -> rename message_identifier to message_id, rename client_id to component_instance_id and component_name to component_id
CommandResponse -> rename message_identifier to message_id, remove error_code, rename request_identifier to request_id
CommandSubscription -> rename client_id to component_instance_id and component_name to component_id, remove message_id, rename command to command_name
QueryEventsResponse -> rename files_completed to historic_events_processed, introduce Void to common.proto and use it as type here
RowResponse -> rename id_values to id_value and sort_values to sort_value
ReadHighestSequenceNrResponse -> rename to_sequence_number to sequence_number
GetEventsRequest -> rename tracking_token to position, rename client_id to component_instance_id and component_name to component_id, remove processor, change the type of PayloadDescription with newly introduced SerializedType and remove PayloadDescription
Event -> rename message_identifier to message_id
QueryValue -> rename to TypedValue and move to common.proto
The text was updated successfully, but these errors were encountered:
This issue covers various findings on the current API design. An implementor(s) may group these findings into subtasks.
If possible rename bidi stream messages to:
Platform(Inbound/Outbound)(Command/Query/Control)Instruction
. Useinstruction_id
i.o.message_id
.common.proto
ErrorMessage
-> renamelocation
tosource
FlowControl
-> deprecateclient_id
ErrorMessage
-> introduceerror_code
as stringcontrol.proto
ClientIdentification
-> renameclient_id
tocomponent_instance_id
, renamecomponent_name
tocomponent_id
SegmentStatus
-> renameone_part_of
tofraction
query.proto
QueryProviderInbound
-> renameQueryRequest
query
parameter toquery_request
QueryRequest
-> renamemessage_identifier
tomessage_id
, renameclient_id
tocomponent_instance_id
, renamecomponent_name
tocomponent_id
QueryComplete
-> removemessage_id
QueryResponse
-> renamemessage_identifier
tomessage_id
, deprecateerror_code
(since it'll be part ofErrorMessage
), check whetherprocessing_instruction
is neededSubscriptionQuery
-> renamesubscription_identifier
tomessage_id
, introduceSerializedType
message as a copy ofSerializedObject
where 3 is reservedQueryUpdate
-> renamemessage_identifier
tomessage_id
, renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
QueryUpdateComplete
-> renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
, rename it toQueryUpdateCompleted
QueryUpdateCompleteExceptionally
-> renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
, rename toQueryUpdateCompletedExceptionally
, deprecateerror_code
SubscriptionQueryRequest
-> reconsider current design - some field types could be adjustedSubscriptionQueryResponse
-> removemessage_identifier
QuerySubscription
-> renamequery
toquery_name
, renameresult_name
toresult_type
, renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
command.proto
Command
-> renamemessage_identifier
tomessage_id
, renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
CommandResponse
-> renamemessage_identifier
tomessage_id
, removeerror_code
, renamerequest_identifier
torequest_id
CommandSubscription
-> renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
, remove message_id, rename command to command_nameevent.proto
Confirmation
-> introduceAppend(Event/Snapshot)Result
TrackingToken
-> renametoken
toposition
EventWithToken
-> renametoken
toposition
QueryEventsResponse
-> renamefiles_completed
tohistoric_events_processed
, introduceVoid
to common.proto and use it as type hereRowResponse
-> renameid_values
toid_value
andsort_values
tosort_value
ReadHighestSequenceNrResponse
-> renameto_sequence_number
tosequence_number
GetEventsRequest
-> renametracking_token
toposition
, renameclient_id
tocomponent_instance_id
andcomponent_name
tocomponent_id
, removeprocessor
, change the type ofPayloadDescription
with newly introducedSerializedType
and removePayloadDescription
Event
-> renamemessage_identifier
tomessage_id
QueryValue
-> rename toTypedValue
and move to common.protoThe text was updated successfully, but these errors were encountered: