[#327] Default local ServiceInstance to a fixed URI i.o. null
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust test to not update the local capabilities, as this reflects the behavior when a node never updates its capabilities since it has not command handlers #327
Default the ServiceInstance to a fixed URI version i.o. null. Doing so, #327
Drop test prefix from tests, as that's the new style #327
Add descriptive JavaDoc to the NoopUriServiceInstance #327
Rename the nop service instance to FixedURIServiceInstance #327
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
|
Kudos, SonarCloud Quality Gate passed! |
gklijs
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request defaults the
ServiceInstanceof theAbstractCapabilityDiscoveryModeto a privateServiceInstancewith a fixedURI.Doing so, we prevent a scenario when the
CapabilityDiscoveryMode#updateLocalCapabilitiesis never invoked, leading to anullServiceInstance.Preventing this scenario ensures that Axon Framework instances that have zero command handlers will not fail on the "is this the local node I am asking capabilities for"-check, when retrieving the capabilities of other instances.
This pull request resolves #327