Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Implement Agency ownership transfer #96612

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

tiagonoronha
Copy link
Contributor

Adds the possibility to transfer the Agency Owner role to a different team member on the agency account.

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/1128.

Proposed Changes

Screenshot 2024-11-21 at 10 38 49 Screenshot 2024-11-21 at 10 38 39

Testing Instructions

  • Sandbox public-api.wordpress.com.
  • Apply D166876-code.
  • In your test agency, invite a user to the agency.
  • Log in as the agency owner, navigate to Team, click on Actions for the user you invited, and select Transfer ownership.
  • A confirmation modal should appear.
  • Click the Transfer ownership button in the confirmation modal.
  • Confirm that the table reloads and you are no longer listed as the agency owner.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~183 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
a8c-for-agencies-team      +1144 B  (+0.1%)     +183 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@tiagonoronha tiagonoronha requested a review from a team November 21, 2024 10:49
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 21, 2024
@tiagonoronha tiagonoronha changed the title Implement Agency ownership transfer A4A: Implement Agency ownership transfer Nov 21, 2024
@cleacos
Copy link
Contributor

cleacos commented Nov 21, 2024

I've tested it partially (I have issues with my sandbox). I can select the Transfer ownership option and I see the confirm modal. The code looks good.

Copy link
Contributor

@vitozev vitozev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiagonoronha tiagonoronha merged commit f4c510a into trunk Nov 22, 2024
15 checks passed
@tiagonoronha tiagonoronha deleted the a4a/agency/transfer-ownership branch November 22, 2024 11:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 22, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17013047

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @tiagonoronha for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 25, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants