Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help Center: Handle closed chats #96460

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

heavyweight
Copy link
Contributor

@heavyweight heavyweight commented Nov 15, 2024

Screenshot 2024-11-18 at 11 37 43

Fixes https://github.com/Automattic/dotcom-forge/issues/9775

Related patch:
D166397-code

Proposed Changes

  • Add footer for closed conversations

Why are these changes being made?

  • Closed interactions should be marked and treated differently

Testing Instructions

  • Checkout the related patch
  • Checkout this PR
  • Using the help-center-experience flag open the support history
  • Start a chat with support
  • Find the relevant ticket in staging, and mark it as solved
  • Open the support history again and locate and open the chat
  • The footer for closed interactions should display
  • Clicking on the button should create a new chat

@matticbot
Copy link
Contributor

matticbot commented Nov 15, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/hc-closed-conversation on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Nov 15, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~246 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center       +867 B  (+0.1%)     +246 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@heavyweight heavyweight marked this pull request as ready for review November 18, 2024 10:40
@heavyweight heavyweight requested a review from a team as a code owner November 18, 2024 10:40
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 18, 2024
@escapemanuele escapemanuele changed the title Handle closed chats Help Center: Handle closed chats Nov 18, 2024
@escapemanuele
Copy link
Contributor

What a great PR!

I'm testing things, meanwhile I spotted a weird hover state on the button

image

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @heavyweight

@renancarvalho
Copy link
Contributor

Nice PR @heavyweight
I have spotted the same as Emanuele, plus I noticed the rating message automatically sent, is it intended
image

@heavyweight
Copy link
Contributor Author

Nice PR @heavyweight I have spotted the same as Emanuele, plus I noticed the rating message automatically sent, is it intended image

This looks like an automation running on staging. We could take a look at it at a later stage.

@heavyweight heavyweight merged commit 7395eac into trunk Nov 22, 2024
9 of 11 checks passed
@heavyweight heavyweight deleted the add/hc-closed-conversation branch November 22, 2024 11:38
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 22, 2024
@a8ci18n
Copy link

a8ci18n commented Nov 22, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17013051

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @heavyweight for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Nov 25, 2024

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants