Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor settings sidebar: Featured image missing grey placeholder box #55566

Open
autumnfjeld opened this issue Aug 18, 2021 · 6 comments
Open
Labels
Needs triage Ticket needs to be triaged [Size] S Small sized issue [Type] Bug

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Aug 18, 2021

The same issue reported in gutenberg WordPress/gutenberg#30904

We should probably try to implement a core first solution (in which case we could close this ticket and work on the GB issue). Ian's suggestion is a nice one, though quite wordy to put all that text in the sidebar. What about a pop-up guide?

Steps to reproduce the behavior

  1. Write a post (do not include a Featured image)
  2. Click on publish
  3. Scroll down to Featured Image in the side menu'
  4. See that the "Set featured image" block is missing

THE EDITOR SETTINGS SIDEBAR :
image

THE SIDEBAR AFRER CLICKING PUBLISH
image

What I expected to happen

The UI for the Featured Image section of the sidebar should be the same in the two scenarios pictured above.

SUGGESTION

Under the grey box, let's a support link to featured image docs:

"Learn about feature images"

This should match the style of other links in the sidebar. For example:
image

@arthur791004
Copy link
Contributor

The UI for the Featured Image section of the sidebar should be the same in the two scenarios pictured above.

Working this one on ampproject/amp-wp#6563

@arthur791004 arthur791004 added the [Size] S Small sized issue label Aug 25, 2021
@p-jackson
Copy link
Member

There seems to be two problems described in this issue description:

  1. The grey "set featured image" button is missing in the pre-publish panel
  2. We should explain what a featured is and why it's important.

I think it makes sense to continue discussion about (2) in the GB repo WordPress/gutenberg#30904

(1) is fixed by ampproject/amp-wp#6563 which has been released in v2.1.4
The amp plugin on atomic sites has been updated to 2.1.4 because I think atomic updates automatically. However simple sites are still running 2.0.5. The last update to 2.0.5 looked pretty involved p58i-9pG-p2. We will need to kick off the process of getting the version updated on simple sites.

I'd say this is no longer a size small 😓

@arthur791004
Copy link
Contributor

Yeah, I only deal with the first one. Oh, I don't know how to update the version for simple sites 😞 Learned and let me take a look for that posts.

@p-jackson
Copy link
Member

p-jackson commented Sep 2, 2021

ampproject/amp-wp#6563 has addressed issue (1), but for the fix to appear on WordPress.com we need to release the AMP plugin. See: pdgK6S-5M-p2

@autumnfjeld
Copy link
Contributor Author

autumnfjeld commented Jan 19, 2022

Work has been done on D66398-code: Update AMP from 2.0.5 to 2.1.4, but we'd like to pass this to the mobile web team, left a request here p1642575120002400-slack-C02DJJ0CLQN.
See more in P2 post: pdgK6S-5M-p2

@p-jackson
Copy link
Member

Just to add my 2c: D66398-code is a proof of concept, feel free to progress this in whatever way makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Size] S Small sized issue [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants