-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Non-Figma Design Systems like CDT #34
Open
ingeniumed
wants to merge
7
commits into
trunk
Choose a base branch
from
add/theme-json-token-starter
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingeniumed
changed the title
Recreate the tokens and theme.json
[WIP] Recreate the tokens and theme.json
Sep 14, 2023
ingeniumed
commented
Sep 14, 2023
ingeniumed
changed the title
[WIP] Recreate the tokens and theme.json
[WIP] Support non-figma Design Systems
Sep 14, 2023
ingeniumed
changed the title
[WIP] Support non-figma Design Systems
[WIP] Support Non-Figma Design Systems like CDT
Sep 14, 2023
…on using a tokenMap
ingeniumed
commented
Sep 14, 2023
ingeniumed
changed the title
[WIP] Support Non-Figma Design Systems like CDT
Support Non-Figma Design Systems like CDT
Sep 14, 2023
smithjw1
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! A few comments that aren't necessary to merge this PR, but something to consider for future work.
…ens into the mapping file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This is a re-creation of #31 as it was accidentally closed)
The purpose of this PR is to support non-figma design systems, such as CDT as a source of truth.
This PR includes 3 key files:
theme.json
that can be used if one doesn't already exist.topTokens.txt
that shows the tokens in thetheme.json
provided.token-map.json
that maps the tokens we have defined intheme.json's
settings.custom
to the ones found in a CSS file. Currently the values line up with thecagov.css
found here.Once this PR is complete,
topTokens.txt
will be deleted and the referencetoken-map.json
will be overriden via CLI arg so it can be tweaked to one's liking.This will fix #32.