Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Non-Figma Design Systems like CDT #34

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from

Conversation

ingeniumed
Copy link
Contributor

@ingeniumed ingeniumed commented Sep 14, 2023

Description

(This is a re-creation of #31 as it was accidentally closed)

The purpose of this PR is to support non-figma design systems, such as CDT as a source of truth.

This PR includes 3 key files:

  • A reference theme.json that can be used if one doesn't already exist.
  • A file called topTokens.txt that shows the tokens in the theme.json provided.
  • A token-map.json that maps the tokens we have defined in theme.json's settings.custom to the ones found in a CSS file. Currently the values line up with the cagov.css found here.

Once this PR is complete, topTokens.txt will be deleted and the reference token-map.json will be overriden via CLI arg so it can be tweaked to one's liking.

This will fix #32.

@ingeniumed ingeniumed requested a review from a team as a code owner September 14, 2023 04:43
@ingeniumed ingeniumed changed the title Recreate the tokens and theme.json [WIP] Recreate the tokens and theme.json Sep 14, 2023
@ingeniumed ingeniumed requested a review from dabowman September 14, 2023 04:54
@ingeniumed ingeniumed changed the title [WIP] Recreate the tokens and theme.json [WIP] Support non-figma Design Systems Sep 14, 2023
@ingeniumed ingeniumed changed the title [WIP] Support non-figma Design Systems [WIP] Support Non-Figma Design Systems like CDT Sep 14, 2023
@ingeniumed ingeniumed changed the title [WIP] Support Non-Figma Design Systems like CDT Support Non-Figma Design Systems like CDT Sep 14, 2023
Copy link

@smithjw1 smithjw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! A few comments that aren't necessary to merge this PR, but something to consider for future work.

@ingeniumed
Copy link
Contributor Author

Screenshot 2023-09-15 at 15 28 02

Here is a screenshot of inserting the values from the top tokens extracted from cagov.css into the twentytwentythree theme. I've used the following blocks:

  • Heading H1 through H6
  • List
  • Column
  • Quote
  • Button
  • Paragraph with a link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for external design systems
2 participants