Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify page with title template and fix title alignment #8423

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Nov 15, 2024

Removes the duplicate template/pattern relationship for just a single template for displaying a page with a title. Also fixes the title display issue where it's not centered. Works nicely alongside #8420, as that adjusts missing spacing between paragraph content and the header/footer.

CleanShot 2024-11-15 at 17 44 09

@richtabor richtabor added [Type] Bug Something isn't working [Theme] Assembler labels Nov 15, 2024
@richtabor richtabor self-assigned this Nov 15, 2024
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Assembler.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Contributor

Theme-Check results

assembler: No changes required ✅.


Copy link
Contributor

@alaczek alaczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - the only thing I'm wondering is if it's going to work seamlessly for customers who are already using this template?

@richtabor
Copy link
Contributor Author

This looks good to me - the only thing I'm wondering is if it's going to work seamlessly for customers who are already using this template?

Yup, sorry I should have included a before/after:

Before After
CleanShot 2024-11-21 at 17 51 10 CleanShot 2024-11-21 at 17 52 04

@richtabor richtabor merged commit 28928ef into trunk Nov 21, 2024
5 checks passed
@richtabor richtabor deleted the assembler/clean-pat branch November 21, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Theme] Assembler [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants