Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Single Choice Option Block's proportion is off/looks squeezed when the theme Assembler is active #7959

Closed
retnonindya opened this issue Jul 11, 2024 · 6 comments · Fixed by #8186
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Pri] TBD [Theme] Assembler Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@retnonindya
Copy link

retnonindya commented Jul 11, 2024

Quick summary

When theme Assembler is active on a website, the Single Choice Option Block's display looks squeezed on the live site. Please refer to the following screenshot:

The button looks normal on the page editor:

Screenshot 2024-07-11 at 11 39 28 AM

On the live site, however, you can see the button looks squeezed:

Screenshot 2024-07-11 at 11 40 17 AM

Steps to reproduce

  1. Create a website (I'm using AT site since this is from user's report and the user's site is AT.)
  2. Make sure the site is on the theme Assembler. You can either use "Build Your Homepage" flow from the WPCOM Themes Directory, or search for the theme Assembler on the WPCOM Themes Directory and activate from ther.
  3. Create a post/page. Preferably page.
  4. Add Form Block, and make sure there is a Single Choice Option (Radio) Block in it.
  5. Inside Single Choice Option (Radio) Block, make sure there is a Single Choice Option Block (child block)/add options
  6. See the radio buttons.
  7. Save the page/publish the page.
  8. Check the page on the live site. Notice the squeezed-look.

What you expected to happen

The radio button stays round

What actually happened

The radio button looks squeezed and not proportional.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Workaround:
Switch theme. In my interaction, I suggested the user switch the theme to TT4.

User report: 8458777-zen

@retnonindya retnonindya added [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report Needs triage Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Jul 11, 2024
@tvolpert
Copy link

tvolpert commented Jul 11, 2024

The min-height setting on all form fields except checkboxes and submit buttons is what appears to be causing this. I'm not sure why we wouldn't have made an exception for radio buttons as well 🤔
Screenshot 2024-07-11 at 9 57 57 AM

This CSS workaround should correct it:

/* correct radio button sizing | XXXXXX-zen tcrv */ 
.contact-form .grunion-field-wrap input.radio {
  min-height: unset;
}
/* End | XXXXXX-zen tcrv */

@mrfoxtalbot mrfoxtalbot transferred this issue from Automattic/wp-calypso Jul 19, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Jul 19, 2024
Copy link
Contributor

github-actions bot commented Jul 19, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8458777-zen
  • -zen
  • 8541929-zen
  • 8823112-zen
  • 9003176-zen

@mikeicode
Copy link

We have run into this on multiple DIFM Express builds using Assembler. I used this CSS:

input[type="radio"] {
	min-height: unset !important;
}

@krutidugade
Copy link

Another report here 8541929-zen. Suggested adding CSS shared by @mikeicode.

@cat-og
Copy link

cat-og commented Oct 15, 2024

8823112-zd-a8c. Provided CSS here as well.

@MikeoMattic
Copy link

9003176-zd-a8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Groundskeeping Worked on by Dotcom Groundskeeping [Pri] Normal [Pri] TBD [Theme] Assembler Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
Development

Successfully merging a pull request may close this issue.

9 participants