Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust spacing between header and title #7144

Closed
donnapep opened this issue Jun 19, 2023 · 0 comments · Fixed by Automattic/sensei#7063 · May be fixed by #7294
Closed

Adjust spacing between header and title #7144

donnapep opened this issue Jun 19, 2023 · 0 comments · Fixed by Automattic/sensei#7063 · May be fixed by #7294
Assignees
@Imran92
Labels
[Pri] Normal [Project] Frontend Improvements [Theme] Course [Type] Bug Something isn't working
Milestone
Course 1.3.3

Comments

@donnapep
Copy link
Contributor

donnapep commented Jun 19, 2023 •
edited
Loading

Steps to replicate

  1. Disable Learning Mode.
  2. Browse to a course.
  3. Browse to a lesson.

I suspect this was broken in the 4.15.0 release.

Result

  • There's not enough whitespace between the header and course & lesson titles.
  • There's too much whitespace between the course / lesson title and the start of the content.

Expected

  • There should be 80px of margin (desktop) and 40px of margin (mobile) between the bottom of the header and the top of the title.
  • There should be 80px of margin (desktop) and 40px of margin (mobile) between the bottom of the title and the top of the content.
  • Learning Mode should not be impacted by these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Imran92 Imran92

Labels
[Pri] Normal [Project] Frontend Improvements [Theme] Course [Type] Bug Something isn't working
Projects
None yet
Milestone
Course 1.3.3
2 participants
@donnapep @Imran92