-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learning mode - Change all question styles for quiz page #7124
Learning mode - Change all question styles for quiz page #7124
Conversation
No theme styles will work otherwise
So that latest block options become available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can go ahead and merge this one if the file upload changes look OK.
Haven't tested it yet, but ❤️ ed the approach of hiding it and using separate element to display and style as we wish. Had to take a kind of similar approach with the radio and checkboxes to style them properly with ease. Looks like this has to be the de-facto way of styling browser native elements like these for frontend (and also editor in some cases) :p |
The file upload button works nicely as expected 💯 Just noticed some minor spacing differences, for example, in gold variation, the button height is 50px instead of 56px like design. But as we've discussed, it's better not to try and match 100% of design in this case as they'll have to definitely go inside theme.json's CSS which may become unmanageable with too many variation specific designs. Just pushed a small PHPCS fix after the approval here 77a43eb. As this is stacked on the footer branch ( #7106), should we merge that one to the feature branch first? Otherwise that PR may become a bit too big to check. |
Yup, this is how all buttons look for the Gold variation right now. I think it's more important to be consistent with existing button styles elsewhere (e.g. Complete Lesson, Take Quiz). If we get some feedback about this, we should be sure to update all buttons and not just the file upload button. 🙂 |
Sure, no problem. The footer PR has a bit of feedback that it would be nice to address prior to merge, but if neither of us can get to it quickly, we can create a new issue for that. |
Thanks @donnapep ! I've checked the footer PR too and only the alignment issue was outstanding. Alignment issue is fixed in this PR for both the questions and the footer |
…into add/change-all-question-styles
…utomattic/sensei into add/change-all-question-styles
Hi @donnapep 👋 Sorry the review got automatically dismissed when I merged the footer branch to the feature branch, as the target branch got changed 😢 As it already got dismissed, I took the opportunity to fix some psalm issues as well. Can you kindly approve again? Thank you! |
327c9e9
into
feature/frontend-improvements
Resolves #7070
Stacked on #7106
This PR contains the styles quiz 'taking' page. As we're working on the LM designs of quiz, not every change of design is applied in the editor, as many CSS styles are applied at runtime overriding the current theme's styles for LM. But the editor styles have been updated too for most font stylings and spacings.
We'll handle the quiz 'submitted' page in another PR.
Proposed Changes
Testing Instructions
There are many combinations here. 7 questions (With and without input) * 4 variations (For course theme only) * 2 states (LM and Non - LM) * different screen sizes. All the states are not matched pixel perfectly, we tried to utilize existing spacings and font sizes wherever possible. So it shouldn't look too much different overall.
Pre-Merge Checklist