Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display default lesson first in lesson wizard #7119

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Aug 18, 2023

Proposed Changes

Change the order of the options in the lesson wizard so that Default Lesson is first. Context - p6rkRX-6Ff-p2

Testing Instructions

  1. Create a new lesson.
  2. Proceed to the second step of the modal.
  3. Check that Default Lesson is listed first.

Screenshot 2023-08-18 at 11 48 06 AM

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@donnapep donnapep added this to the 4.16.2 milestone Aug 18, 2023
@donnapep donnapep self-assigned this Aug 18, 2023
@donnapep donnapep requested a review from a team August 18, 2023 16:03
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #7119 (df272d4) into trunk (10ab5fe) will not change coverage.
Report is 4 commits behind head on trunk.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              trunk    #7119   +/-   ##
=========================================
  Coverage     49.37%   49.37%           
  Complexity    10544    10544           
=========================================
  Files           575      575           
  Lines         44529    44529           
  Branches        402      402           
=========================================
  Hits          21986    21986           
  Misses        22216    22216           
  Partials        327      327           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85297b6...df272d4. Read the comment docs.

Copy link
Contributor

@Imran92 Imran92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@donnapep donnapep merged commit 33afd2c into trunk Aug 18, 2023
24 checks passed
@donnapep donnapep deleted the update/lesson-layouts-order branch August 18, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants