Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-fix issues found by Psalm #7098

Closed
wants to merge 2 commits into from
Closed

Auto-fix issues found by Psalm #7098

wants to merge 2 commits into from

Conversation

merkushin
Copy link
Member

Resolves #7094

Proposed Changes

Testing Instructions

New/Updated Hooks

Deprecated Code

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Acceptance criteria is met
  • Decisions are publicly documented
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • New UIs match the designs
  • Different user privileges (admin, teacher, subscriber) are tested as appropriate
  • Code is tested on the minimum supported PHP and WordPress versions
  • User interface changes have been tested on the latest versions of Chrome, Firefox and Safari
  • "Needs Documentation" label is added if this change requires updates to documentation
  • Known issues are created as new GitHub issues

@merkushin merkushin added this to the 4.16.2 milestone Aug 15, 2023
@merkushin merkushin requested a review from a team August 15, 2023 12:52
@merkushin merkushin self-assigned this Aug 15, 2023
@merkushin
Copy link
Member Author

That was a bad idea to apply autofix.
I drowned in fixes after autofixes.
So, I'm just creating a baseline.
We can address all the issues manually.

@merkushin merkushin closed this Aug 15, 2023
@merkushin merkushin deleted the fix/autofix-with-psalm branch August 15, 2023 23:25
@donnapep donnapep removed this from the 4.16.2 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@merkushin merkushin

Labels
No Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merkushin @donnapep