-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quiz navigation and title area in learning mode #7093
Conversation
WordPress Dependencies ReportThe
This comment was automatically generated by the |
Codecov Report
@@ Coverage Diff @@
## trunk #7093 +/- ##
============================================
- Coverage 49.37% 49.36% -0.01%
- Complexity 10544 10546 +2
============================================
Files 575 575
Lines 44529 44537 +8
Branches 402 402
============================================
+ Hits 21986 21987 +1
- Misses 22216 22223 +7
Partials 327 327
Continue to review full report in Codecov by Sentry.
|
…sign-learning-mode
…sign-learning-mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! I've left some feedback.
I realized that I forgot about the editor 😱 and there are some styles there that don't match the frontend. How would you prefer to handle the editor for this card and also moving forward for other cards?
I think it'll be better if we create separate cards for editor. I've realized we're having some issues like theme.json styles not getting applied in the editor for some blocks. Having separate cards will probably be helpful |
Oof. OK, I created #7112 for the editor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This will make it easier to write theme-specific CSS.
This fixes spacing issues on GeneratePress.
c136793
to
996400a
Compare
Thanks for the updates Donna <3 All looks good to me. The body class was breaking the button styles like below for me in Course theme, so I've added a fix here 4b9baeb |
Oof. Good catch. I think it's a bit dangerous to add |
Resolves #7072
Proposed Changes
Testing Instructions
Screenshots
Pre-Merge Checklist